Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial updates from Ivan, #2 #441

Merged
merged 6 commits into from
Nov 4, 2020
Merged

Editorial updates from Ivan, #2 #441

merged 6 commits into from
Nov 4, 2020

Conversation

rhiaro
Copy link
Member

@rhiaro rhiaro commented Oct 25, 2020 •
edited by pr-preview bot
Loading

I ran through #403 and this PR contains the suggested changes that are editorial and uncontroversial; see individual commits for details.

Preview | Diff

@rhiaro rhiaro added the editorial Editors should update the spec then close label Oct 25, 2020
iherman
iherman approved these changes Oct 25, 2020
View reviewed changes
Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put check marks in #403 that, I believe, are covered by this PR. @rhiaro you should also check this, please.

@iherman iherman mentioned this pull request Oct 27, 2020
Closed
30 tasks
@msporny
Copy link
Member

msporny commented Nov 1, 2020

Please fix merge conflicts, good to go after that.

@rhiaro rhiaro force-pushed the rhiaro-403-editorial branch from dceb9d0 to 2593704 Compare November 2, 2020 08:51
@rhiaro
Copy link
Member Author

rhiaro commented Nov 2, 2020

Rebased and fixed conflicts

@msporny
Copy link
Member

msporny commented Nov 4, 2020

Editorial, multiple positive reviews, no objections, merging.

@msporny msporny merged commit f2faaeb into master Nov 4, 2020
@msporny msporny deleted the rhiaro-403-editorial branch November 8, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentzundel brentzundel brentzundel approved these changes

@iherman iherman iherman approved these changes

@msporny msporny msporny approved these changes

@peacekeeper peacekeeper Awaiting requested review from peacekeeper

Assignees
No one assigned
Labels
editorial Editors should update the spec then close
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhiaro @msporny @iherman @brentzundel