Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: option element mapping table #2365

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Oct 30, 2024

This PR does a few things:

  1. Adds text indicating that UAs should calculate the x of y position of options similar to radio buttons (this is what happens now, but was not specified)
  2. Re: the above mentioned x of y (aria-posinset / aria-setsize) for options, the radio button text that this was pulled from had a few wording updates to keep consistency.
  3. adds UA MAY to comments of option, indicating what could be done to correct for invalid nesting of interactive elements within options (per upcoming customizable select where this scenario could occur)

related to whatwg/html#10586 (among other customizable select prs/issues)

Test, Documentation and Implementation tracking

Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.

  • "author MUST" tests:
  • "user agent MUST" tests:
  • Browser implementations (link to issue or commit):
    • WebKit:
    • Gecko:
    • Blink:
  • Does this need AT implementations?
  • Related APG Issue/PR:
  • MDN Issue/PR:

This PR does a few things:

1. Adds text indicating that UAs should calculate the x of y position of options similar to radio buttons (this is what happens now, but was not specified)
2. Re: the above mentioned x of y (aria-posinset / aria-setsize) for options, the radio button text that this was pulled from had a few wording updates to keep consistency.
3. adds UA MAY to comments of option, indicating what could be done to correct for invalid nesting of interactive elements within options (per upcoming customizable select where this scenario could occur)
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 6e4452c
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/675a03bd0f756d0008df4046
😎 Deploy Preview https://deploy-preview-2365--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@scottaohara
Copy link
Member Author

scottaohara commented Oct 30, 2024

this PR might also need to include an entry for the option element into the accName steps in html aam... specifically regarding the use of the label attribute if that does something beyond just adding/replacing text of the option.

EDIT: in the open ui call we resolved that the label attribute should continue doing what it does for the current select, and that if an author uses it, it'll take priority in displaying its text, rather than whatever the author uses as the nested content of the option. so:

<option label="i am what is shown as the text content of the option">i do not get displayed</option>

also, might be worth calling out that - at least as far as i recall - option in the current select doesnt' always support aria-label, since the UA presented listbox/options didn't always carry over aria-attributes (again, last i recall this wasn't supported everywhere)

this commit also contains commented out content to address w3c/html-aam#568 in a future PR
html-aam/index.html Outdated Show resolved Hide resolved
@scottaohara scottaohara marked this pull request as ready for review November 7, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants