State that resolve() does nothing outside of continue_on #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm1
approved these changes
Apr 15, 2025
|
I couldn't find the issue, do you happen to have it? |
|
Oh I think this was something we noticed over chat, there appears to be no issue |
samuelgoto
reviewed
Apr 15, 2025
spec/index.bs
Outdated
| @@ -1733,6 +1733,10 @@ their phone number. To allow for such flows, the [=IDP=] must call | |||
|
|
|||
| See the [=show an IDP login dialog=] algorithm for more details. | |||
|
|
|||
| {{IdentityProvider/resolve}} is used while a [=show a continuation | |||
| dialog|continuation dialog=] is shown to return a specific token to the [=RP=] | |||
| as described below. If called at any other time, it does nothing. | |||
There was a problem hiding this comment.
Suggested change
| as described below. If called at any other time, it does nothing. | |
| as described below. If called at any other time, it throws an Error. |
Shouldn't we be throwing an error perhaps?
Not sure, and also, not implemented, but just wanted to raise whether "does nothing" is the right thing ...
There was a problem hiding this comment.
Fair point. Changed it to reject with an InvalidStateError.
There was a problem hiding this comment.
Yes rejecting is better. Is this what the implementation does?
There was a problem hiding this comment.
After checking the implementation, it does reject with an error, but it uses NotAllowedError. I changed this PR to use that error as well.
(This makes Ted's suggestion moot)
TallTed
reviewed
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff