Skip to content

Codex/bcs bot v1 contract - #7

Open
Emotion403 wants to merge 2 commits into
vzvince:devfrom
Emotion403:codex/bcs-bot-v1-contract
Open

Codex/bcs bot v1 contract#7
Emotion403 wants to merge 2 commits into
vzvince:devfrom
Emotion403:codex/bcs-bot-v1-contract

Conversation

@Emotion403

Copy link
Copy Markdown

Problem

Solution

Validation

Compatibility and risk (optional)

Spec (optional)

Related issues (optional)

@Emotion403
Emotion403 requested a review from vzvince as a code owner August 2, 2026 09:13
@vzvince

vzvince commented Aug 2, 2026

Copy link
Copy Markdown
Owner

@codex review

@Emotion403
Emotion403 force-pushed the codex/bcs-bot-v1-contract branch from 6a65260 to 534d8e8 Compare August 2, 2026 09:22

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a652603f8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +11 to +12
/openapi/v1/bots/{bot_id}:
$ref: ./openapi/bots.yaml#/BotPath

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Move the contract off the backend-owned bots route

In the checked gateway configuration (src/gateway/configs/application.yaml), every /openapi/v1/bots/** request is routed to the Backend, which already implements GET /openapi/v1/bots/{bot_id} with its own incompatible Bot model in src/backend/src/agentclaw/community/adapters/http/openapi_v1/bots/router.py; meanwhile, the BCS V1 router merges no Bot routes. Consequently, clients of this new BCS contract will reach the Backend handler rather than the declared BCS operation (and the other new Bot operations will return 404/405). Use a BCS-owned namespace or coordinate the gateway and serving implementation before adding this path to the authoritative contract.

AGENTS.md reference: AGENTS.md:L56-L61

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants