Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces: T7268: Add op-mode command for show all interfaces on system #4447

Open
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

l0crian1
Copy link
Contributor

Change summary

This change adds a command to show all interfaces on the host system; not just those that are configurable by VyOS. This will allow the API to pull interfaces for dashboards that have been created by additionally installed packages or containers.

Syntax:
show interfaces kernel
show interfaces kernel json

show interfaces kernel <interface>
show interfaces kernel <interface> json

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7268

Related PR(s)

How to test / Smoketest result

show interfaces kernel
show interfaces kernel json
show interfaces kernel <interface>
show interfaces kernel <interface> json

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This creates a command to show all interfaces on the system in both human readable and JSON format.

This includes non-VyOS interfaces like those created by containers.

Syntax:
show interfaces kernel
show interfaces kernel json

show interfaces kernel <interface>
show interfaces kernel <interface> json
Copy link

👍
No issues in PR Title / Commit Title

Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests ❌ failed
  • RAID1 tests ❌ failed
  • TPM tests ❌ failed

Copy link
Member

@sarthurdev sarthurdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmbaturin can confirm, but I believe all new op-mode should be using the new standard in a src/op_mode script so that it can also be called via API.

@l0crian1
Copy link
Contributor Author

@dmbaturin can confirm, but I believe all new op-mode should be using the new standard in a src/op_mode script so that it can also be called via API.

This can be called by REST, just not GraphQL. I was actually targeting this command for the REST calls specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants