bridge: T7322: fix slow performance of allowed vlan #4444
+21
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2025 11:03
Allowed VLAN ranges are unnecessarily deconstructed into individual vlans, and then added one by one to the bridge. This can take a long time if a large range like 1-4084 is used. - python/vyos/configdict.py - Added get_vlans_ids_and_range function to return configured ranges - python/vyos/ifconfig/bridge.py - Modified add and delete vlan section to not loop unnecessarily
Fix indentation error in get_vlans_ids_and_range function.
|
❌ |
l0crian1
changed the title
|
CI integration 👍 passed! Details
|
c-po
requested changes
Apr 11, 2025
c-po
approved these changes
Apr 13, 2025
c-po
added
bp/sagitta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Ranges that are configured in allowed-vlans (e.g. 1-4094), are deconstructed into all of their individual VLANs, which is unnecessary for the execution of these:
bridge vlan add dev {interface} vid {vlan} masterbridge vlan del dev {interface} vid {vlan} masterThis leads to a very long commit time when doing large ranges. This change eliminates that unnecessary deconstruction.
Example:
Execution time of
allowed-vlans 1-4094in current state: 38.94 secondsExecution time of
allowed-vlans 1-4094without unnecessary deconstruction of range: 4.94 secondsTypes of changes
Related Task(s)
https://vyos.dev/T7322
Related PR(s)
How to test / Smoketest result
set interfaces bridge br0 member interface eth0 allowed-vlan 1-4094You will see a massive improvement on commit times, especially on slower systems.
Checklist: