Skip to content

fix: Use this.name instead of hardcoded provider name in OpenAIResponsesProvider.getModels() #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acoliver merged 2 commits into from
Jan 28, 2026
Merged

fix: Use this.name instead of hardcoded provider name in OpenAIResponsesProvider.getModels() #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70b529d
fix: Use this.name instead of hardcoded provider name in OpenAIRespon…
acoliver Jan 28, 2026
197d47d
Merge branch 'main' into issue1209
acoliver Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/core/src/providers/openai-responses/OpenAIResponsesProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ export class OpenAIResponsesProvider extends BaseProvider {
return RESPONSES_API_MODELS.map((modelId) => ({
id: modelId,
name: modelId,
provider: 'openai-responses',
provider: this.name,
supportedToolFormats: ['openai'],
}));
}
Expand Down Expand Up @@ -242,7 +242,7 @@ export class OpenAIResponsesProvider extends BaseProvider {
models.push({
id: model.id,
name: model.id,
provider: 'openai-responses',
provider: this.name,
supportedToolFormats: ['openai'],
});
}
Expand All @@ -253,7 +253,7 @@ export class OpenAIResponsesProvider extends BaseProvider {
: RESPONSES_API_MODELS.map((modelId) => ({
id: modelId,
name: modelId,
provider: 'openai-responses',
provider: this.name,
supportedToolFormats: ['openai'],
}));
}
Expand All @@ -265,7 +265,7 @@ export class OpenAIResponsesProvider extends BaseProvider {
return RESPONSES_API_MODELS.map((modelId) => ({
id: modelId,
name: modelId,
provider: 'openai-responses',
provider: this.name,
supportedToolFormats: ['openai'],
}));
}
Expand Down
20 changes: 20 additions & 0 deletions ...ages/core/src/providers/openai-responses/__tests__/OpenAIResponsesProvider.models.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,4 +139,24 @@ describe('OpenAIResponsesProvider - Codex Model Listing', () => {
expect(gpt51?.name).toBe('gpt-5.1');
});
});

it('should use this.name for provider field so aliases work correctly', async () => {
const provider = new OpenAIResponsesProvider(
undefined,
'https://api.openai.com/v1',
);

Object.defineProperty(provider, 'name', {
value: 'my-alias',
writable: false,
enumerable: true,
configurable: true,
});

const models = await provider.getModels();

for (const model of models) {
expect(model.provider).toBe('my-alias');
}
});
});
Loading