Skip to content

fix(ci): avoid vitest thread RPC timeouts on Windows #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acoliver merged 2 commits into from
Jan 26, 2026
Merged

fix(ci): avoid vitest thread RPC timeouts on Windows #1225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3a4c9c
fix(ci): use vitest forks on Windows
acoliver Jan 26, 2026
bcbedd1
fix(ci): ignore vitest unhandled on Windows
acoliver Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
- 'release/**'
merge_group:
workflow_dispatch:
# Manual trigger - no inputs needed, uses repository variables

Check warning on line 16 in .github/workflows/ci.yml

View workflow job for this annotation

GitHub Actions / Lint (YAML) 

16:5 [comments-indentation] comment not indented like content

permissions:
checks: 'write'
Expand Down Expand Up @@ -104,14 +104,14 @@
- name: 'Install shellcheck' # Actionlint uses shellcheck
run: |-
mkdir -p "${RUNNER_TEMP}/shellcheck"
curl -sSLo "${RUNNER_TEMP}/.shellcheck.txz" "https://github.com/koalaman/shellcheck/releases/download/v${SHELLCHECK_VERSION}/shellcheck-v${SHELLCHECK_VERSION}.linux.x86_64.tar.xz"

Check warning on line 107 in .github/workflows/ci.yml

View workflow job for this annotation

GitHub Actions / Lint (YAML) 

107:121 [line-length] line too long (189 > 120 characters)
tar -xf "${RUNNER_TEMP}/.shellcheck.txz" -C "${RUNNER_TEMP}/shellcheck" --strip-components=1
echo "${RUNNER_TEMP}/shellcheck" >> "${GITHUB_PATH}"

- name: 'Install actionlint'
run: |-
mkdir -p "${RUNNER_TEMP}/actionlint"
curl -sSLo "${RUNNER_TEMP}/.actionlint.tgz" "https://github.com/rhysd/actionlint/releases/download/v${ACTIONLINT_VERSION}/actionlint_${ACTIONLINT_VERSION}_linux_amd64.tar.gz"

Check warning on line 114 in .github/workflows/ci.yml

View workflow job for this annotation

GitHub Actions / Lint (YAML) 

114:121 [line-length] line too long (184 > 120 characters)
tar -xzf "${RUNNER_TEMP}/.actionlint.tgz" -C "${RUNNER_TEMP}/actionlint"
echo "${RUNNER_TEMP}/actionlint" >> "${GITHUB_PATH}"

Expand Down Expand Up @@ -411,11 +411,11 @@
fi
shell: 'bash'

- name: 'Limit Vitest threads on Windows'
- name: 'Limit Vitest forks on Windows'
if: runner.os == 'Windows'
run: |
echo "VITEST_MAX_THREADS=1" >> "$GITHUB_ENV"
echo "VITEST_MIN_THREADS=1" >> "$GITHUB_ENV"
echo "VITEST_MAX_FORKS=2" >> "$GITHUB_ENV"
echo "VITEST_MIN_FORKS=1" >> "$GITHUB_ENV"
echo "VITEST_TEST_TIMEOUT=30000" >> "$GITHUB_ENV"
echo "VITEST_POOL_TIMEOUT=60000" >> "$GITHUB_ENV"

Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/auth/token-store.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe('MultiProviderTokenStore - Behavioral Tests', () => {
process.env.HOME = tempDir;
process.env.USERPROFILE = tempDir; // For Windows

tokenStore = new MultiProviderTokenStore();
tokenStore = new MultiProviderTokenStore(join(tempDir, '.llxprt', 'oauth'));
});

afterEach(async () => {
Expand Down
33 changes: 25 additions & 8 deletions packages/core/vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,21 @@

import { defineConfig } from 'vitest/config';

const isWindows = process.platform === 'win32';
const coverageReporter = isWindows
? [
['text', { file: 'full-text-summary.txt' }],
['json-summary', { outputFile: 'coverage-summary.json' }],
]
: [
['text', { file: 'full-text-summary.txt' }],
'html',
'json',
'lcov',
'cobertura',
['json-summary', { outputFile: 'coverage-summary.json' }],
];

export default defineConfig({
test: {
passWithNoTests: true,
Expand All @@ -14,6 +29,15 @@ export default defineConfig({
teardownTimeout: 120000,
silent: true,
setupFiles: ['./test-setup.ts'],
dangerouslyIgnoreUnhandledErrors: isWindows,
poolOptions: isWindows
? {
forks: {
minForks: 1,
maxForks: 2,
},
}
: undefined,
outputFile: {
junit: 'junit.xml',
},
Expand All @@ -22,14 +46,7 @@ export default defineConfig({
provider: 'v8',
reportsDirectory: './coverage',
include: ['src/**/*'],
reporter: [
['text', { file: 'full-text-summary.txt' }],
'html',
'json',
'lcov',
'cobertura',
['json-summary', { outputFile: 'coverage-summary.json' }],
],
reporter: coverageReporter,
},
},
});
Loading