Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ice Cream Flavor #2

Merged
merged 2 commits into from
Mar 11, 2020

Conversation

jischr
Copy link
Contributor

@jischr jischr commented Mar 11, 2020

This PR adds my ice cream flavor to the list of ice cream flavors in FavoriteIceCreamFlavor/FavoriteIceCreamFlavor.md

Relevant Issue = #1

Copy link
Owner

@vuinguyen vuinguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready! Please change that to an ice cream flavor 🍨

@@ -10,3 +10,4 @@ Your answer should be in the following format:
Add your answer below the last entry in this list:

- Cherry Garcia, Vui Nguyen, @vuinguyen
- Sour Cream and Onion Kettle Chips, Jen Winer, @jenniferwiner
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that's not a potato chip flavor? 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! good call. will update now!

Copy link
Owner

@vuinguyen vuinguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 👍 Good job, @jenniferwiner ! 🎆

@vuinguyen vuinguyen merged commit 5ecd54a into vuinguyen:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants