Skip to content

fix(watchPausable): remove incorrect deprecation - #5640

Open
kerimsarginnn wants to merge 1 commit into
vueuse:mainfrom
kerimsarginnn:fix/watch-pausable-deprecation
Open

kerimsarginnn wants to merge 1 commit into
vueuse:mainfrom
kerimsarginnn:fix/watch-pausable-deprecation

Conversation

@kerimsarginnn

Copy link
Copy Markdown

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
  • Confirm that this PR is based on your own understanding and review of the project, not solely generated or summarized by AI tools.

Note: If this PR is deemed to be primarily generated by AI tools, it may be closed.

⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Additional context

Copilot AI lite review requested due to automatic review settings September 18, 2026 06:59
@agentscanapp

agentscanapp Bot commented Sep 18, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! 🎉

We really appreciate you taking the time to contribute, @kerimsarginnn.

A maintainer will take a look as soon as they can. In the meantime, please make sure that:

  • the description explains what changed and why
  • any related issues are linked
  • existing tests still pass

If anything needs adjusting we'll leave comments here. Thanks again!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Regenerate the tsnapi snapshot and checked-in skills reference to remove stale deprecation metadata.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Removes incorrect deprecation guidance from watchPausable and clarifies its pause/resume behavior.

Changes:

  • Removes deprecated API annotations.
  • Adds a regression assertion for resume().
  • Updates package documentation.
File summaries
File Summary
packages/shared/watchPausable/index.ts Removes deprecation annotations.
packages/shared/watchPausable/index.test.ts Verifies resuming does not invoke the callback.
packages/shared/watchPausable/index.md Clarifies pause/resume behavior.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/shared/watchPausable/index.ts
Comment thread packages/shared/watchPausable/index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants