fix(watchPausable): remove incorrect deprecation - #5640
Open
kerimsarginnn wants to merge 1 commit into
Open
kerimsarginnn wants to merge 1 commit into
kerimsarginnn wants to merge 1 commit into
Conversation
Thanks for opening this pull request! 🎉We really appreciate you taking the time to contribute, @kerimsarginnn. A maintainer will take a look as soon as they can. In the meantime, please make sure that:
If anything needs adjusting we'll leave comments here. Thanks again! |
There was a problem hiding this comment.
🟡 Changes recommended
Regenerate the tsnapi snapshot and checked-in skills reference to remove stale deprecation metadata.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Removes incorrect deprecation guidance from watchPausable and clarifies its pause/resume behavior.
Changes:
- Removes deprecated API annotations.
- Adds a regression assertion for
resume(). - Updates package documentation.
File summaries
| File | Summary |
|---|---|
packages/shared/watchPausable/index.ts |
Removes deprecation annotations. |
packages/shared/watchPausable/index.test.ts |
Verifies resuming does not invoke the callback. |
packages/shared/watchPausable/index.md |
Clarifies pause/resume behavior. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123).Description
Additional context