Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message #1756

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve error message #1756

wants to merge 1 commit into from

Conversation

yamacent
Copy link

close #1694

@yamacent yamacent force-pushed the improve-error-message branch from 337174d to 7cc90dd Compare October 30, 2020 12:35
haoqunjiang
haoqunjiang requested changes Oct 31, 2020
View reviewed changes
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! But could you add a test case for this feature? Because if it's a compile-time error, I doubt such code would have any effect.

@yamacent
Copy link
Author

yamacent commented Nov 4, 2020

@sodatea
Thanks for the comment!
This PR tries to replace the runtime error message Uncaught TypeError: Cannot set property 'render' of undefined.
Do you think it should be compile-time error? And can that realize with small change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add specific error message when there is no default export for a Component
2 participants
@yamacent @haoqunjiang