Updates typescript to 2.7.1 version #686
Conversation
| @@ -294,7 +295,7 @@ export function getJavascriptMode( | |||
| const program = service.getProgram(); | |||
| definitions.forEach(d => { | |||
| const sourceFile = program.getSourceFile(d.fileName); | |||
There was a problem hiding this comment.
definitive assertion should add here. Getting sourceFile from declaration is expected to be non null.
There was a problem hiding this comment.
I think I doesn't get that. getSourceFile returns ts.SourceFile | undefined in 2.7.1. To get rid of errors I had add to add exclamation mark on 298. It is not allowed to add it on line:col (296:25). Another solution is to add if with return statement.
There was a problem hiding this comment.
| public closed: boolean; | ||
| public endTagStart: number; | ||
| public attributes: { [name: string]: string }; | ||
| public tag!: string; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Since 2.7.1 it isn't allowed to declare properties without initialization when strict flag is set inside tsconfig. Typescript throws there error even though you null check that later.
There was a problem hiding this comment.
You can declare it as optional or typing it as string | undefined
| @@ -37,7 +37,7 @@ export function getTagProviderSettings(workspacePath: string | null | undefined) | |||
| return settings; | |||
| } | |||
| try { | |||
| const packagePath = ts.findConfigFile(workspacePath, ts.sys.fileExists, 'package.json'); | |||
| const packagePath = ts.findConfigFile(workspacePath, ts.sys.fileExists, 'package.json') || ''; | |||
There was a problem hiding this comment.
If package is not found, it should return early. Empty path doesn't make much sense.
| @@ -27,7 +27,7 @@ export function testDSL(setup: CompletionTestSetup): (text: TemplateStringsArray | |||
| } | |||
|
|
|||
| export class CompletionAsserter { | |||
| lastMatch: CompletionItem; | |||
| lastMatch!: CompletionItem; | |||
There was a problem hiding this comment.
It looks like lastMatch is better modeled as CompletionItem | undefined. https://github.com/vuejs/vetur/pull/686/files#diff-8c1c99640c5e32e1403b16bc16ec3849R61
But I'm fine with current writing since lastMatch is always called after has.
|
I didn't write htmlParser myself, but it seems most parser's properties are indeed optional. I don't think bang them all is a good practice. @goszczynskip Would you please declare them as optional? |
|
Sure, I'll do that but I can push changes this evening. |
|
I don't think updating TS dependency like this is a long-term solution. First, user still can't select TS versions. Second, TS updates also bring in a lot of updates in the LS API which powers all language features in the But I'm not against upgrading to 2.7.1 or having |
|
I can totally agree with that. I think one solution would be to select ts version on bottom bar, the same way you choose for .ts files. Right now I see this PR as quick update to let users benefit from eg. Definite assignment assertions |
|
Thanks, upgrading looks good! We can solve #682 later. Upgrading itself is good to merge. |
|
Any chance we can get a release with this out? I'd like to fix microsoft/TypeScript-Vue-Starter#36, but know users will report issues in Vetur. |
In this TS version Definite assignment assertions were added, that's why this PR contains more than just package update.