Skip to content

fix(vscode): syntax highlighting error if type declaration at the end of script block #5256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

zhiyuanzmj
Copy link
Member

closed #2060

Before:
image

After:
image

Copy link

pkg-pr-new bot commented Mar 6, 2025

Open in StackBlitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5256

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5256

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5256

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5256

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5256

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5256

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5256

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5256

commit: 343437b

@johnsoncodehk
Copy link
Member

Thanks for the PR, but this is an upstream issue: microsoft/TypeScript-TmLanguage#873

We cannot add this patch fix on our side because we cannot maintain of it's complexity. Most importantly, since this introduces inconsistencies in TS syntax highlights, we cannot verify whether it will cause other regressions.

@johnsoncodehk johnsoncodehk deleted the fix/#2060 branch May 18, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax highlighting requires new-line or semi-colon between script blocks.
2 participants