Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-core): always use destructure syntax to pass props type #5043

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KazariEX
Copy link
Collaborator

re-fix #1232

Copy link

pkg-pr-new bot commented Dec 11, 2024

Open in Stackblitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5043

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5043

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5043

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5043

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5043

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5043

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5043

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5043

commit: c54f614

@KazariEX KazariEX changed the title fix(language-core): default use of destructure syntax to pass props type fix(language-core): always use destructure syntax to pass props type Dec 11, 2024
@johnsoncodehk johnsoncodehk force-pushed the master branch 4 times, most recently from c3e80dc to 209717c Compare December 20, 2024 21:05
@johnsoncodehk
Copy link
Member

Since we have discovered that destructuring can significantly impact type evaluation performance, we need to consider this solution carefully.

@KazariEX KazariEX marked this pull request as draft December 21, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default export of the module has or is using private name 'Props'
3 participants