-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create with vue-i18n #548
Closed
Closed
Changes from 12 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
0709a51
feat: create with vue-i18n
Procrustes5 807f730
chore(test): add tests
Procrustes5 4da6366
Update pnpm-lock.yaml
Procrustes5 007c98b
fix(ci): add generated files
Procrustes5 a8764b5
fix(ci): set entrypoints ts
Procrustes5 cd6b00f
Revert "fix(ci): add generated files"
Procrustes5 3c8210b
fix: change index.js like vue-i18n document
Procrustes5 047817d
Merge branch 'main' into feat/create-with-i18n
Procrustes5 f4b7e2f
chore: pnpm-lock.yaml
Procrustes5 afd0352
Merge branch 'feat/create-with-i18n' of https://github.com/Procrustes…
Procrustes5 aebef03
Update pnpm-lock.yaml
Procrustes5 b2c996a
feat: add flags to snapshot
Procrustes5 e5c6f33
Merge branch 'main' into feat/create-with-i18n
Procrustes5 a44a4e8
fix: remove template/tsconfig/vue-i18n
Procrustes5 3acbe52
Merge branch 'feat/create-with-i18n' of https://github.com/Procrustes…
Procrustes5 8f7ccff
chore: fix package.json
Procrustes5 0d4a933
chore: pull main
Procrustes5 b3fa7e0
feat: add ts files
Procrustes5 d098768
fix: cd.yml
Procrustes5 d51fd03
Merge branch 'main' into feat/create-with-i18n
Procrustes5 cf5d71e
chore: export i18n
Procrustes5 cd0b81a
Merge branch 'feat/create-with-i18n' of https://github.com/Procrustes…
Procrustes5 3a83d52
feat: add views
Procrustes5 17fb167
chore: typo
Procrustes5 c7922a6
chore: delete i18n on matrix
Procrustes5 026cd9e
chore: avoid lint error
Procrustes5 884b9dd
chore: disable eslint
Procrustes5 ad66d81
chore: test
Procrustes5 a125bc7
chore: export i18n
Procrustes5 d2bf4f4
fix: delete duplicated files
Procrustes5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
<script setup lang="ts"> | ||
import HelloWorld from './components/HelloWorld.vue' | ||
import TheWelcome from './components/TheWelcome.vue' | ||
</script> | ||
|
||
<template> | ||
<header> | ||
<img alt="Vue logo" class="logo" src="./assets/logo.svg" width="125" height="125" /> | ||
|
||
<div class="wrapper"> | ||
<HelloWorld msg="You did it!" /> | ||
</div> | ||
</header> | ||
|
||
<main> | ||
<TheWelcome /> | ||
</main> | ||
</template> | ||
|
||
<style scoped> | ||
header { | ||
line-height: 1.5; | ||
} | ||
|
||
.logo { | ||
display: block; | ||
margin: 0 auto 2rem; | ||
} | ||
|
||
@media (min-width: 1024px) { | ||
header { | ||
display: flex; | ||
place-items: center; | ||
padding-right: calc(var(--section-gap) / 2); | ||
} | ||
|
||
.logo { | ||
margin: 0 2rem 0 0; | ||
} | ||
|
||
header .wrapper { | ||
display: flex; | ||
place-items: flex-start; | ||
flex-wrap: wrap; | ||
} | ||
} | ||
</style> | ||
45 changes: 45 additions & 0 deletions
45
template/code/typescript-i18n/src/components/HelloWorld.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
<script setup lang="ts"> | ||
import { useI18n } from 'vue-i18n' | ||
|
||
defineProps<{ | ||
msg: string | ||
}>() | ||
|
||
const { t } = useI18n() | ||
</script> | ||
|
||
<template> | ||
<div class="greetings"> | ||
<h1 class="green">{{ msg }}</h1> | ||
<h3> | ||
{{ t('greetings.message') }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
<a href="https://vitejs.dev/" target="_blank" rel="noopener">Vite</a> + | ||
<a href="https://vuejs.org/" target="_blank" rel="noopener">Vue 3</a>. | ||
</h3> | ||
</div> | ||
</template> | ||
|
||
<style scoped> | ||
h1 { | ||
font-weight: 500; | ||
font-size: 2.6rem; | ||
position: relative; | ||
top: -10px; | ||
} | ||
|
||
h3 { | ||
font-size: 1.2rem; | ||
} | ||
|
||
.greetings h1, | ||
.greetings h3 { | ||
text-align: center; | ||
} | ||
|
||
@media (min-width: 1024px) { | ||
.greetings h1, | ||
.greetings h3 { | ||
text-align: left; | ||
} | ||
} | ||
</style> |
88 changes: 88 additions & 0 deletions
88
template/code/typescript-i18n/src/components/TheWelcome.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
<script setup lang="ts"> | ||
import WelcomeItem from './WelcomeItem.vue' | ||
import DocumentationIcon from './icons/IconDocumentation.vue' | ||
import ToolingIcon from './icons/IconTooling.vue' | ||
import EcosystemIcon from './icons/IconEcosystem.vue' | ||
import CommunityIcon from './icons/IconCommunity.vue' | ||
import SupportIcon from './icons/IconSupport.vue' | ||
</script> | ||
|
||
<template> | ||
<WelcomeItem> | ||
<template #icon> | ||
<DocumentationIcon /> | ||
</template> | ||
<template #heading>Documentation</template> | ||
|
||
Vue’s | ||
<a href="https://vuejs.org/" target="_blank" rel="noopener">official documentation</a> | ||
provides you with all information you need to get started. | ||
</WelcomeItem> | ||
|
||
<WelcomeItem> | ||
<template #icon> | ||
<ToolingIcon /> | ||
</template> | ||
<template #heading>Tooling</template> | ||
|
||
This project is served and bundled with | ||
<a href="https://vitejs.dev/guide/features.html" target="_blank" rel="noopener">Vite</a>. The | ||
recommended IDE setup is | ||
<a href="https://code.visualstudio.com/" target="_blank" rel="noopener">VSCode</a> + | ||
<a href="https://github.com/johnsoncodehk/volar" target="_blank" rel="noopener">Volar</a>. If | ||
you need to test your components and web pages, check out | ||
<a href="https://www.cypress.io/" target="_blank" rel="noopener">Cypress</a> and | ||
<a href="https://on.cypress.io/component" target="_blank" rel="noopener" | ||
>Cypress Component Testing</a | ||
>. | ||
|
||
<br /> | ||
|
||
More instructions are available in <code>README.md</code>. | ||
</WelcomeItem> | ||
|
||
<WelcomeItem> | ||
<template #icon> | ||
<EcosystemIcon /> | ||
</template> | ||
<template #heading>Ecosystem</template> | ||
|
||
Get official tools and libraries for your project: | ||
<a href="https://pinia.vuejs.org/" target="_blank" rel="noopener">Pinia</a>, | ||
<a href="https://router.vuejs.org/" target="_blank" rel="noopener">Vue Router</a>, | ||
<a href="https://test-utils.vuejs.org/" target="_blank" rel="noopener">Vue Test Utils</a>, and | ||
<a href="https://github.com/vuejs/devtools" target="_blank" rel="noopener">Vue Dev Tools</a>. If | ||
you need more resources, we suggest paying | ||
<a href="https://github.com/vuejs/awesome-vue" target="_blank" rel="noopener">Awesome Vue</a> | ||
a visit. | ||
</WelcomeItem> | ||
|
||
<WelcomeItem> | ||
<template #icon> | ||
<CommunityIcon /> | ||
</template> | ||
<template #heading>Community</template> | ||
|
||
Got stuck? Ask your question on | ||
<a href="https://chat.vuejs.org" target="_blank" rel="noopener">Vue Land</a>, our official | ||
Discord server, or | ||
<a href="https://stackoverflow.com/questions/tagged/vue.js" target="_blank" rel="noopener" | ||
>StackOverflow</a | ||
>. You should also subscribe to | ||
<a href="https://news.vuejs.org" target="_blank" rel="noopener">our mailing list</a> and follow | ||
the official | ||
<a href="https://twitter.com/vuejs" target="_blank" rel="noopener">@vuejs</a> | ||
twitter account for latest news in the Vue world. | ||
</WelcomeItem> | ||
|
||
<WelcomeItem> | ||
<template #icon> | ||
<SupportIcon /> | ||
</template> | ||
<template #heading>Support Vue</template> | ||
|
||
As an independent project, Vue relies on community backing for its sustainability. You can help | ||
us by | ||
<a href="https://vuejs.org/sponsor/" target="_blank" rel="noopener">becoming a sponsor</a>. | ||
</WelcomeItem> | ||
</template> |
87 changes: 87 additions & 0 deletions
87
template/code/typescript-i18n/src/components/WelcomeItem.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
<template> | ||
<div class="item"> | ||
<i> | ||
<slot name="icon"></slot> | ||
</i> | ||
<div class="details"> | ||
<h3> | ||
<slot name="heading"></slot> | ||
</h3> | ||
<slot></slot> | ||
</div> | ||
</div> | ||
</template> | ||
|
||
<style scoped> | ||
.item { | ||
margin-top: 2rem; | ||
display: flex; | ||
position: relative; | ||
} | ||
|
||
.details { | ||
flex: 1; | ||
margin-left: 1rem; | ||
} | ||
|
||
i { | ||
display: flex; | ||
place-items: center; | ||
place-content: center; | ||
width: 32px; | ||
height: 32px; | ||
|
||
color: var(--color-text); | ||
} | ||
|
||
h3 { | ||
font-size: 1.2rem; | ||
font-weight: 500; | ||
margin-bottom: 0.4rem; | ||
color: var(--color-heading); | ||
} | ||
|
||
@media (min-width: 1024px) { | ||
.item { | ||
margin-top: 0; | ||
padding: 0.4rem 0 1rem calc(var(--section-gap) / 2); | ||
} | ||
|
||
i { | ||
top: calc(50% - 25px); | ||
left: -26px; | ||
position: absolute; | ||
border: 1px solid var(--color-border); | ||
background: var(--color-background); | ||
border-radius: 8px; | ||
width: 50px; | ||
height: 50px; | ||
} | ||
|
||
.item:before { | ||
content: ' '; | ||
border-left: 1px solid var(--color-border); | ||
position: absolute; | ||
left: 0; | ||
bottom: calc(50% + 25px); | ||
height: calc(50% - 25px); | ||
} | ||
|
||
.item:after { | ||
content: ' '; | ||
border-left: 1px solid var(--color-border); | ||
position: absolute; | ||
left: 0; | ||
top: calc(50% + 25px); | ||
height: calc(50% - 25px); | ||
} | ||
|
||
.item:first-of-type:before { | ||
display: none; | ||
} | ||
|
||
.item:last-of-type:after { | ||
display: none; | ||
} | ||
} | ||
</style> |
7 changes: 7 additions & 0 deletions
7
template/code/typescript-i18n/src/components/icons/IconCommunity.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<template> | ||
<svg xmlns="http://www.w3.org/2000/svg" width="20" height="20" fill="currentColor"> | ||
<path | ||
d="M15 4a1 1 0 1 0 0 2V4zm0 11v-1a1 1 0 0 0-1 1h1zm0 4l-.707.707A1 1 0 0 0 16 19h-1zm-4-4l.707-.707A1 1 0 0 0 11 14v1zm-4.707-1.293a1 1 0 0 0-1.414 1.414l1.414-1.414zm-.707.707l-.707-.707.707.707zM9 11v-1a1 1 0 0 0-.707.293L9 11zm-4 0h1a1 1 0 0 0-1-1v1zm0 4H4a1 1 0 0 0 1.707.707L5 15zm10-9h2V4h-2v2zm2 0a1 1 0 0 1 1 1h2a3 3 0 0 0-3-3v2zm1 1v6h2V7h-2zm0 6a1 1 0 0 1-1 1v2a3 3 0 0 0 3-3h-2zm-1 1h-2v2h2v-2zm-3 1v4h2v-4h-2zm1.707 3.293l-4-4-1.414 1.414 4 4 1.414-1.414zM11 14H7v2h4v-2zm-4 0c-.276 0-.525-.111-.707-.293l-1.414 1.414C5.42 15.663 6.172 16 7 16v-2zm-.707 1.121l3.414-3.414-1.414-1.414-3.414 3.414 1.414 1.414zM9 12h4v-2H9v2zm4 0a3 3 0 0 0 3-3h-2a1 1 0 0 1-1 1v2zm3-3V3h-2v6h2zm0-6a3 3 0 0 0-3-3v2a1 1 0 0 1 1 1h2zm-3-3H3v2h10V0zM3 0a3 3 0 0 0-3 3h2a1 1 0 0 1 1-1V0zM0 3v6h2V3H0zm0 6a3 3 0 0 0 3 3v-2a1 1 0 0 1-1-1H0zm3 3h2v-2H3v2zm1-1v4h2v-4H4zm1.707 4.707l.586-.586-1.414-1.414-.586.586 1.414 1.414z" | ||
/> | ||
</svg> | ||
</template> |
7 changes: 7 additions & 0 deletions
7
template/code/typescript-i18n/src/components/icons/IconDocumentation.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<template> | ||
<svg xmlns="http://www.w3.org/2000/svg" width="20" height="17" fill="currentColor"> | ||
<path | ||
d="M11 2.253a1 1 0 1 0-2 0h2zm-2 13a1 1 0 1 0 2 0H9zm.447-12.167a1 1 0 1 0 1.107-1.666L9.447 3.086zM1 2.253L.447 1.42A1 1 0 0 0 0 2.253h1zm0 13H0a1 1 0 0 0 1.553.833L1 15.253zm8.447.833a1 1 0 1 0 1.107-1.666l-1.107 1.666zm0-14.666a1 1 0 1 0 1.107 1.666L9.447 1.42zM19 2.253h1a1 1 0 0 0-.447-.833L19 2.253zm0 13l-.553.833A1 1 0 0 0 20 15.253h-1zm-9.553-.833a1 1 0 1 0 1.107 1.666L9.447 14.42zM9 2.253v13h2v-13H9zm1.553-.833C9.203.523 7.42 0 5.5 0v2c1.572 0 2.961.431 3.947 1.086l1.107-1.666zM5.5 0C3.58 0 1.797.523.447 1.42l1.107 1.666C2.539 2.431 3.928 2 5.5 2V0zM0 2.253v13h2v-13H0zm1.553 13.833C2.539 15.431 3.928 15 5.5 15v-2c-1.92 0-3.703.523-5.053 1.42l1.107 1.666zM5.5 15c1.572 0 2.961.431 3.947 1.086l1.107-1.666C9.203 13.523 7.42 13 5.5 13v2zm5.053-11.914C11.539 2.431 12.928 2 14.5 2V0c-1.92 0-3.703.523-5.053 1.42l1.107 1.666zM14.5 2c1.573 0 2.961.431 3.947 1.086l1.107-1.666C18.203.523 16.421 0 14.5 0v2zm3.5.253v13h2v-13h-2zm1.553 12.167C18.203 13.523 16.421 13 14.5 13v2c1.573 0 2.961.431 3.947 1.086l1.107-1.666zM14.5 13c-1.92 0-3.703.523-5.053 1.42l1.107 1.666C11.539 15.431 12.928 15 14.5 15v-2z" | ||
/> | ||
</svg> | ||
</template> |
7 changes: 7 additions & 0 deletions
7
template/code/typescript-i18n/src/components/icons/IconEcosystem.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<template> | ||
<svg xmlns="http://www.w3.org/2000/svg" width="18" height="20" fill="currentColor"> | ||
<path | ||
d="M11.447 8.894a1 1 0 1 0-.894-1.789l.894 1.789zm-2.894-.789a1 1 0 1 0 .894 1.789l-.894-1.789zm0 1.789a1 1 0 1 0 .894-1.789l-.894 1.789zM7.447 7.106a1 1 0 1 0-.894 1.789l.894-1.789zM10 9a1 1 0 1 0-2 0h2zm-2 2.5a1 1 0 1 0 2 0H8zm9.447-5.606a1 1 0 1 0-.894-1.789l.894 1.789zm-2.894-.789a1 1 0 1 0 .894 1.789l-.894-1.789zm2 .789a1 1 0 1 0 .894-1.789l-.894 1.789zm-1.106-2.789a1 1 0 1 0-.894 1.789l.894-1.789zM18 5a1 1 0 1 0-2 0h2zm-2 2.5a1 1 0 1 0 2 0h-2zm-5.447-4.606a1 1 0 1 0 .894-1.789l-.894 1.789zM9 1l.447-.894a1 1 0 0 0-.894 0L9 1zm-2.447.106a1 1 0 1 0 .894 1.789l-.894-1.789zm-6 3a1 1 0 1 0 .894 1.789L.553 4.106zm2.894.789a1 1 0 1 0-.894-1.789l.894 1.789zm-2-.789a1 1 0 1 0-.894 1.789l.894-1.789zm1.106 2.789a1 1 0 1 0 .894-1.789l-.894 1.789zM2 5a1 1 0 1 0-2 0h2zM0 7.5a1 1 0 1 0 2 0H0zm8.553 12.394a1 1 0 1 0 .894-1.789l-.894 1.789zm-1.106-2.789a1 1 0 1 0-.894 1.789l.894-1.789zm1.106 1a1 1 0 1 0 .894 1.789l-.894-1.789zm2.894.789a1 1 0 1 0-.894-1.789l.894 1.789zM8 19a1 1 0 1 0 2 0H8zm2-2.5a1 1 0 1 0-2 0h2zm-7.447.394a1 1 0 1 0 .894-1.789l-.894 1.789zM1 15H0a1 1 0 0 0 .553.894L1 15zm1-2.5a1 1 0 1 0-2 0h2zm12.553 2.606a1 1 0 1 0 .894 1.789l-.894-1.789zM17 15l.447.894A1 1 0 0 0 18 15h-1zm1-2.5a1 1 0 1 0-2 0h2zm-7.447-5.394l-2 1 .894 1.789 2-1-.894-1.789zm-1.106 1l-2-1-.894 1.789 2 1 .894-1.789zM8 9v2.5h2V9H8zm8.553-4.894l-2 1 .894 1.789 2-1-.894-1.789zm.894 0l-2-1-.894 1.789 2 1 .894-1.789zM16 5v2.5h2V5h-2zm-4.553-3.894l-2-1-.894 1.789 2 1 .894-1.789zm-2.894-1l-2 1 .894 1.789 2-1L8.553.106zM1.447 5.894l2-1-.894-1.789-2 1 .894 1.789zm-.894 0l2 1 .894-1.789-2-1-.894 1.789zM0 5v2.5h2V5H0zm9.447 13.106l-2-1-.894 1.789 2 1 .894-1.789zm0 1.789l2-1-.894-1.789-2 1 .894 1.789zM10 19v-2.5H8V19h2zm-6.553-3.894l-2-1-.894 1.789 2 1 .894-1.789zM2 15v-2.5H0V15h2zm13.447 1.894l2-1-.894-1.789-2 1 .894 1.789zM18 15v-2.5h-2V15h2z" | ||
/> | ||
</svg> | ||
</template> |
7 changes: 7 additions & 0 deletions
7
template/code/typescript-i18n/src/components/icons/IconSupport.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<template> | ||
<svg xmlns="http://www.w3.org/2000/svg" width="20" height="20" fill="currentColor"> | ||
<path | ||
d="M10 3.22l-.61-.6a5.5 5.5 0 0 0-7.666.105 5.5 5.5 0 0 0-.114 7.665L10 18.78l8.39-8.4a5.5 5.5 0 0 0-.114-7.665 5.5 5.5 0 0 0-7.666-.105l-.61.61z" | ||
/> | ||
</svg> | ||
</template> |
19 changes: 19 additions & 0 deletions
19
template/code/typescript-i18n/src/components/icons/IconTooling.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
<!-- This icon is from <https://github.com/Templarian/MaterialDesign>, distributed under Apache 2.0 (https://www.apache.org/licenses/LICENSE-2.0) license--> | ||
<template> | ||
<svg | ||
xmlns="http://www.w3.org/2000/svg" | ||
xmlns:xlink="http://www.w3.org/1999/xlink" | ||
aria-hidden="true" | ||
role="img" | ||
class="iconify iconify--mdi" | ||
width="24" | ||
height="24" | ||
preserveAspectRatio="xMidYMid meet" | ||
viewBox="0 0 24 24" | ||
> | ||
<path | ||
d="M20 18v-4h-3v1h-2v-1H9v1H7v-1H4v4h16M6.33 8l-1.74 4H7v-1h2v1h6v-1h2v1h2.41l-1.74-4H6.33M9 5v1h6V5H9m12.84 7.61c.1.22.16.48.16.8V18c0 .53-.21 1-.6 1.41c-.4.4-.85.59-1.4.59H4c-.55 0-1-.19-1.4-.59C2.21 19 2 18.53 2 18v-4.59c0-.32.06-.58.16-.8L4.5 7.22C4.84 6.41 5.45 6 6.33 6H7V5c0-.55.18-1 .57-1.41C7.96 3.2 8.44 3 9 3h6c.56 0 1.04.2 1.43.59c.39.41.57.86.57 1.41v1h.67c.88 0 1.49.41 1.83 1.22l2.34 5.39z" | ||
fill="currentColor" | ||
></path> | ||
</svg> | ||
</template> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file necessary? If it doesn't change from the
typescript-default
versions, then I think it should not be duplicated if possible (same for the other components).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cexbrayat
Oh, I'd not understood this architecture yet. Thank you
modified now!