Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(customElement): handle configure app work with async component #12607

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #12448

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+66 B) 38 kB (+20 B) 34.2 kB (+41 B)
vue.global.prod.js 158 kB (+66 B) 57.8 kB (+14 B) 51.5 kB (+63 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.3 kB 18.2 kB 16.6 kB
createApp 54.2 kB 21.1 kB 19.3 kB
createSSRApp 58.4 kB 22.9 kB 20.8 kB
defineCustomElement 59.1 kB (+66 B) 22.7 kB (+17 B) 20.7 kB (+8 B)
overall 68.3 kB 26.3 kB 23.9 kB

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: custom elements labels Dec 25, 2024
Copy link

pkg-pr-new bot commented Dec 25, 2024

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12607

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12607

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12607

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12607

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12607

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12607

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12607

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12607

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12607

vue

npm i https://pkg.pr.new/vue@12607

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12607

commit: 85e2850

@vuejs vuejs deleted a comment from vue-bot Dec 25, 2024
@vue-bot
Copy link
Contributor

vue-bot commented Dec 25, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success failure
nuxt failure success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: custom elements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configureApp for defineCustomElement Not Executed for Async Components
2 participants