feat: implement onFocus callback inside InputSearch #1445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Related: vtex-apps/store-components#1074
The
InputSearchcomponent is not calling theonFocuscallback that can be set on the props. This creates an issue as described inside the store-components. When theInputSearchcomponent is being rendered as the main searchbar, the autocomplete is not opened by default if this is configured.What problem is this solving?
This solves the issue of the non-appearing auto-complete bar when using the
inputType: searchconfiguration on thesearchbarcomponent.How should this be manually tested?
Steps to reproduce the behavior:
{ "props": { "openAutocompleteOnFocus": true, "inputType": "search" } }Expected behavior
The autocomplete should be expanded showing
top searchesandsearch historyScreenshots or example usage
current result

fix

Types of changes