Add packed normals#31
Open
jamierobertson1 wants to merge 1 commit intovsg-dev:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for normals packed into a 32 bit integer (10 bits each component). Currently only used when the ASCII Reader reads a sufficient number of fields (assumes x,y,z,r,g,b,nx,ny,nz ASCII format), if normals are detected then the phong shader is automatically used.
This does increase the memory overhead a bit when generating data sets slightly due to the increased size of
vsgPoints::PackedPoint.Ideally there could be different PackedPoint variants depending on formats of points (e.g. xyz, xyzrgb, xyzn and other combinations of colours, normals etc, possibly intensity also).
Tested on windows.