Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig.mod: needs workaround.c #180

Merged
merged 1 commit into from
Feb 14, 2025
Merged

zig.mod: needs workaround.c #180

merged 1 commit into from
Feb 14, 2025

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Feb 14, 2025

finally getting around to updating https://github.com/nektro/zig-zorm to 0.13 (i know 😅) and got the following error before applying this patch:

error: ld.lld: undefined symbol: sqliteTransientAsDestructor
    note: referenced by sqlite.zig:1679 (/home/meghan/dev/.zigmod/deps/git/github.com/vrischmann/zig-sqlite/sqlite.zig:1679)
    note:               /home/meghan/zig-cache/o/af79a354004d379e876ff5cb8d995080/test.o:(sqlite.DynamicStatement.bindField__anon_7594)

@vrischmann
Copy link
Owner

Thanks !

@vrischmann vrischmann merged commit cd7d1c3 into vrischmann:master Feb 14, 2025
5 checks passed
@vrischmann
Copy link
Owner

I'm just realising that zig.mod depends on having the sqlite C file in the repo.

I'm planning on dropping the vendored C file and leverage the zig build system to fetch the sqlite amalgamation instead (see #178 for context).
Does zigmod have a way to do this too ? Otherwise I'm probably going to have to drop support for zigmod :/

@nektro nektro deleted the patch-1 branch February 14, 2025 11:25
@nektro
Copy link
Contributor Author

nektro commented Feb 14, 2025

yeah! something like this should also work great:
https://github.com/nektro/zig-sqlite3/blob/f62e628aa281ffd9b4976fd58229533b65c38550/zig.mod

@vrischmann
Copy link
Owner

Thanks, i'll check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants