-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add support for multi-service and multi-port binding WSDL files #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi-service and multi-port binding WSDL files #1337
Conversation
|
Will have a look in this one later. It is in my backlog. |
fyi: I am working on a test for this one when have time, but due to other issues in this project this is not a first priority. |
|
Was looking into this past week. Still not sure I understand the problem because I managed to create a WSDL file that breaks it. Anyway, I continue investigating this. At least I have a good WSDL and a template for a test. |
4802783 to
2b39cf4
Compare
Fix timeouts in some tests when test fail Fix test asserion when validate soap error
This reverts commit bac8b3b.
|
Reverted original change, I think it is not correct, moreover it does not fix anything. Instead fixed looked through service->port bindings. Added new multi-service/multi-port WSDL and new tests. @smokhov would you be able to review this, in case I overlooked something? |
I had a look at the changes, you've done quite a comprehensive test coverage for the issue, so I think it's good to go. I guess the code has improved since the times of the original PR so the original change became redundant, but it's nice now to have it fully covered as well. |
This PR supersedes PR #1226 (by @paulish). For now simply sync'ing it with
master. Unsure yet what type of test it would have... It seems covered? But I don't have a concrete example in mind.