migrate away from erb #357
Conversation
b4ldr
force-pushed
the
migrate_to_epp
branch
2 times, most recently
from
95232a6 to
f1c8e1b
Compare
| # @summary Remove blank lines from a string | ||
| # @param content The content to remove blank lines from | ||
| # @return The content with blank lines removed | ||
| function unbound::clean_blank_lines ( |
There was a problem hiding this comment.
I think this is generic enough that it could also be part of extlib?
There was a problem hiding this comment.
| $config_file = $unbound::config_file, | ||
| Array[Unbound::Resource_record_type] $local_data = [], | ||
| String $template_name = 'unbound/local_zone.erb' | ||
| Unbound::Local_zone_type $type, |
There was a problem hiding this comment.
I prefer the older style, with just a single whitespace. That makes the diff easier to read and makes git reverts / cherry-picks easier. But there's no consent in our style guide yet.
There was a problem hiding this comment.
I hear you but the rest of this module uses this style and I prefer consistency. But consistency across viz would be great so let's try and get something in the style guide and then we can creat a puppet lint check and fix to get everything fixed?
| ) { | ||
| $records = $local_data.map |$record| { |
There was a problem hiding this comment.
there's a lot going on here. Can you please add some comments about what's happening?
There was a problem hiding this comment.
Updated let me know what's missing?
| ) { | ||
| $records = $local_data.map |$record| { |
There was a problem hiding this comment.
Updated let me know what's missing?
| # @summary Remove blank lines from a string | ||
| # @param content The content to remove blank lines from | ||
| # @return The content with blank lines removed | ||
| function unbound::clean_blank_lines ( |
There was a problem hiding this comment.
update the templating code to move away from erb and where possible use the print_config function
This PR is currently a WIP, couple of outstanding things
Also happy to split this up into separate PRs if needed