Skip to content

Nrpe::Syslogfacility -> Stdlib::Syslogfacility#22

Open
bastelfreak wants to merge 1 commit intovoxpupuli:masterfrom
bastelfreak:types
Open

Nrpe::Syslogfacility -> Stdlib::Syslogfacility#22
bastelfreak wants to merge 1 commit intovoxpupuli:masterfrom
bastelfreak:types

Conversation

@bastelfreak
Copy link
Member

@bastelfreak bastelfreak commented Mar 9, 2019

The syslogfacility type is present in stdlib, so we should use it.
Before merging this,
puppetlabs/puppetlabs-stdlib#1005 needs to be
released. We also need to update metadata.json

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak
Nrpe::Syslogfacility -> Stdlib::Syslogfacility
d285603 
The syslogfacility type is present in stdlib, so we should use it.
Before merging this,
puppetlabs/puppetlabs-stdlib#1005 needs to be
released. We also need to update metadata.json
@vox-pupuli-tasks
Copy link

vox-pupuli-tasks bot commented May 1, 2020

Dear @bastelfreak, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

vox-pupuli-tasks bot commented Jul 29, 2020

Dear @bastelfreak, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tests-fail

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bastelfreak