BulletEngine

[mrzzzrm]

Depends on #563 #568
Fixes #414

Code still needs cleanup and doc, maybe Line::intersects() can be optimised, but here it is: the BulletEngine

• Bullets of one kind are handled by the BulletEngine, if they have general.instanced=true
• The BulletEngine draws Bullets of one kind instanced. That means more rendering performance and almost no overhead (which was quite significant for me) creating those bullets.
• InstancedBullets are moved much more efficient, using just one Line-WorldTreeQuery per frame

Please test it and report back. Expect significant improvements in the F2 battle, but there are still perfproblems with splitdetection and in VoxelRenderData::updateBuffer() (when using the homebase)

[psieg]

afaik emissiveness should be 0.0 - 1.0, has something changed?

[psieg]

generally looking good. couldn't enjoy the performance because I'm on laptop on battery
this is going to be fun to merge with transparency...

[psieg]

Not sure this rename is good. I thing we're going to run in a name conflict here, because a WorldElement - as far as I understood - will be anything that's part of the world, including scripts, triggers, (internal)engines etc.
This builder (which actually is a factory or something as we found out^^) can only build these voxelbased things. Maybe another abstract class in this hierarchy is needed that is an "Object in a world" which consists of voxels and can be drawn or something.... what a worldobject used to be

[psieg]

(repost)
Not sure this rename is good. I thing we're going to run in a name conflict here, because a WorldElement - as far as I understood - will be anything that's part of the world, including scripts, triggers, (internal)engines etc.
This builder (which actually is a factory or something as we found out^^) can only build these voxelbased things. Maybe another abstract class in this hierarchy is needed that is an "Object in a world" which consists of voxels and can be drawn or something.... what a worldobject used to be

[mrzzzrm]

I consent, but can't really think of a a good name for a base class of InstancedBullet AND WorldObject... VoxelObject maybe... ideas?

[psieg]

Voxelobject doesn't sound too bad. Maybe - since this is all voxels - you can even drop the voxels and have an ObjectBuilder or ObjectFactory, because objects in our World are things that are spawned, moved, deleted and have a physical representation (position) in the world

[mrzzzrm]

Beside the naming of the WorldElementBuilder, anything else?

[gersseba]

I agree with the renaming, voxelobject sounds good. Runs smooth on my machine, code looks fine after renaming.
But I think this is a major change so maybe wait for a second shipit

[mrzzzrm]

Did the renaming ;)

[psieg]

weren't we about to de-singletonize the world to allow sectors? because there is an awful lot of World::instance() in this diff.

[mrzzzrm]

I don't think the de-singletonizing was for this PR. I have a pretty complete branch (that misses some other things) for sectors where World::instance() is gone, though

[psieg]

is there a PR for that? If both should be merged... In order to not have the trouble when merging, maybe this feature should already be built without needing that lateron. Just a suggestion

[mrzzzrm]

I made this mergeable again and looked over the code once more. I would probably solve it more generically today, but I think it is fine as it is. What do you think, one more shipit?