Added support for unprefixed "eligible_authroles" and "eligible_authids" #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n publish messages, in accordance with the standard. For backwards compatibility, the prefixed versions "_thruway_eligible_authroles" and "_thruway_eligible_authids" are still preferred if both prefixed and unprefixed variant are specified.
boenrobot
force-pushed
the
unprefixed-eligibles
branch
from
4a83b75 to
c57aa42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see any reason why those shouldn't be supported, seeing as they are a thing in the WAMP spec now.
I'm guessing once upon a time, they weren't, so this prefixed version was added? I've added support for the unprefixed one in what I think is a backwards compatible fashion, for any users who are already using the prefixed version.