-
Notifications
You must be signed in to change notification settings - Fork 85
Feature: FixedSizeListVector
#5127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
565060f to
5f7016d
Compare
CodSpeed Performance ReportMerging #5127 will not alter performanceComparing Summary
Benchmarks breakdown
Footnotes
|
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5f7016d to
b1d3df1
Compare
ab28178 to
d7bead6
Compare
FixedSizeListVector.FixedSizeListVector
47f1bee to
ab24047
Compare
| true, // Vectors are always nullable. | ||
| )); | ||
|
|
||
| Ok(Arc::new(FixedSizeListArray::try_new( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe leave a todo with the Arrow bug linked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't run into the same arrow bug since vectors are always nullable
Signed-off-by: Connor Tsui <[email protected]>
Adds `VectorOps` implementations for `FixedSizeList` vectors plus other convenient methods (constructors and `into_arrow`). Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
ab24047 to
b85bf84
Compare
Tracking Issue: #5028