Skip to content

Conversation

@connortsui20
Copy link
Contributor

Tracking Issue: #5028

@connortsui20 connortsui20 added the feature Release label indicating a new feature or request label Oct 30, 2025
@connortsui20 connortsui20 marked this pull request as draft October 30, 2025 19:20
@connortsui20 connortsui20 mentioned this pull request Oct 30, 2025
38 tasks
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 30, 2025

CodSpeed Performance Report

Merging #5127 will not alter performance

Comparing ct/vv-fsl (b85bf84) with develop (69ef61d)1

Summary

✅ 1318 untouched
🆕 7 new
⏩ 127 skipped2

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 decompress[("alp_for_bp_f64", 0x768a00)] N/A 24.2 ms N/A
🆕 decompress[("datetime_for_bp", 0x76bce0)] N/A 34.9 ms N/A
🆕 decompress[("dict_fsst_varbin_bp_string", 0x76adf0)] N/A 14.5 ms N/A
🆕 decompress[("dict_fsst_varbin_string", 0x76a760)] N/A 14.5 ms N/A
🆕 decompress[("dict_varbinview_string", 0x769420)] N/A 14.7 ms N/A
🆕 decompress[("for_bp_u64", 0x7682b0)] N/A 2.5 ms N/A
🆕 decompress[("runend_for_bp_u32", 0x7698b0)] N/A 2 ms N/A

Footnotes

  1. No successful run was found on develop (7634f36) during the generation of this report, so 69ef61d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 127 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 79.04968% with 97 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.86%. Comparing base (69ef61d) to head (b85bf84).
⚠️ Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-vector/src/fixed_size_list/vector_mut.rs 88.75% 29 Missing ⚠️
vortex-vector/src/fixed_size_list/vector.rs 87.17% 20 Missing ⚠️
vortex-vector/src/vector_mut.rs 0.00% 14 Missing ⚠️
vortex-compute/src/arrow/fixed_size_list.rs 0.00% 12 Missing ⚠️
vortex-vector/src/vector.rs 0.00% 12 Missing ⚠️
vortex-vector/src/fixed_size_list/mod.rs 0.00% 6 Missing ⚠️
vortex-compute/src/mask/mod.rs 0.00% 4 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from ct/vv-cleanup-struct to develop October 30, 2025 20:22
@connortsui20 connortsui20 changed the title Feature: FixedSizeListVector. Feature: FixedSizeListVector Nov 3, 2025
@connortsui20 connortsui20 force-pushed the ct/vv-fsl branch 3 times, most recently from 47f1bee to ab24047 Compare November 3, 2025 20:05
@connortsui20 connortsui20 marked this pull request as ready for review November 3, 2025 20:07
@connortsui20 connortsui20 requested review from a10y and gatesn November 3, 2025 20:07
true, // Vectors are always nullable.
));

Ok(Arc::new(FixedSizeListArray::try_new(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe leave a todo with the Arrow bug linked?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't run into the same arrow bug since vectors are always nullable

Adds `VectorOps` implementations for `FixedSizeList` vectors plus other
convenient methods (constructors and `into_arrow`).

Signed-off-by: Connor Tsui <[email protected]>
@gatesn gatesn merged commit 625273e into develop Nov 4, 2025
41 checks passed
@gatesn gatesn deleted the ct/vv-fsl branch November 4, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Release label indicating a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants