Skip to content

Conversation

@peasee
Copy link

@peasee peasee commented Oct 30, 2025

Description

  • Adds a VortexWriterOptionsFactory to allow someone using Vortex via the DataFusion VortexFormat implementation to be able to pass down custom writer options (e.g. for determining layout structure, etc). I've created a factory without a Handle, so the values can be copied into a VortexWriterOptions whilst finding an active handle at the time the write occurs.
  • Made some opinionated changes to VortexFormat and VortexFormatFactory. Instead of ::new_with_options(), prefers a more fleshed out builder pattern with ::new().with_options().with_writer_options_factory(). This is a breaking change (anyone using ::new_with_options must now use ::new().with_options()).

@peasee peasee force-pushed the fix/allow-writer-options-for-datafusion branch from 9ccedff to e35aeec Compare October 30, 2025 00:52
@joseph-isaacs joseph-isaacs added the feature Release label indicating a new feature or request label Oct 30, 2025
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 79.00000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.79%. Comparing base (ffd8429) to head (d41b220).
⚠️ Report is 79 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-file/src/writer.rs 75.86% 14 Missing ⚠️
vortex-datafusion/src/persistent/format.rs 76.66% 7 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@peasee peasee force-pushed the fix/allow-writer-options-for-datafusion branch from 6cb982a to d41b220 Compare October 30, 2025 23:02
@AdamGS
Copy link
Contributor

AdamGS commented Nov 3, 2025

LGTM, just needs fixing the clippy error and we can merge it

@peasee
Copy link
Author

peasee commented Nov 6, 2025

Looks like this was made redundant by #5111

@peasee peasee closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Release label indicating a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants