Merged
Conversation
Collaborator
|
Great stuff, and thanks - I didn't even notice in prepping 1.7.0 that Travis was kaput.. I really appreciate this MR, thank you! /approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Life is easier with smoothly running CI. I have ported CI to use GitHub Actions. For now, I have introduced only supported Ruby and Rails versions.
If welcomed, I can contribute to new version supporting only those (do some cleanups in code and README.md) and we can cut new major release.
Otherwise I can try to port older versions to CI as well.
Other possible improvement is to move Rails edge CI to weekly build, ping me if that would be welcomed as well.
PS: You can see CI in action at RubyElders#1.