Skip to content

fix: reset stale state on plugin re-load to handle double-load by OpenClaw Gateway #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r266-tech wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −2
Open

fix: reset stale state on plugin re-load to handle double-load by OpenClaw Gateway #1214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
680450b
fix: reset stale state on plugin re-load to handle double-load by Ope…
wzrrrrrrr Apr 4, 2026
0cfb582
fix: add missing client parameters in defensive re-spawn path
r266-tech Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions examples/openclaw-plugin/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,8 @@ function totalCommitMemories(r: CommitSessionResult): number {
return Object.values(m).reduce((sum, n) => sum + (n ?? 0), 0);
}

let _registered = false;

const contextEnginePlugin = {
id: "openviking",
name: "Context Engine (OpenViking)",
Expand All @@ -270,6 +272,17 @@ const contextEnginePlugin = {
configSchema: memoryOpenVikingConfigSchema,

register(api: OpenClawPluginApi) {
// Idempotency guard: when OpenClaw reloads the plugin with a different cacheKey,
// module-level state (localClientCache, localClientPendingPromises) persists from
// the previous load. Reset stale state so the second registration works cleanly.
// See: https://github.com/volcengine/OpenViking/issues/1210
if (_registered) {
api.logger.info("openviking: plugin re-loaded, resetting stale state");
localClientCache.clear();
localClientPendingPromises.clear();
}
_registered = true;

const rawCfg =
api.pluginConfig && typeof api.pluginConfig === "object" && !Array.isArray(api.pluginConfig)
? (api.pluginConfig as Record<string, unknown>)
Expand Down Expand Up @@ -1215,7 +1228,15 @@ const contextEnginePlugin = {
});
try {
await waitForHealthOrExit(baseUrl, timeoutMs, intervalMs, child);
const client = new OpenVikingClient(baseUrl, cfg.apiKey, cfg.agentId, cfg.timeoutMs);
const client = new OpenVikingClient(
baseUrl,
cfg.apiKey,
cfg.agentId,
cfg.timeoutMs,
tenantAccount,
tenantUser,
routingDebugLog,
);
localClientCache.set(localCacheKey, { client, process: child });
if (resolveLocalClient) {
resolveLocalClient(client);
Expand Down Expand Up @@ -1360,4 +1381,4 @@ export async function buildMemoryLinesWithBudget(
return { lines, estimatedTokens: totalTokens };
}

export default contextEnginePlugin;
export default contextEnginePlugin;
Loading