Skip to content

test/e2e: fix flake in WaitForModelServingReady #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vyagh wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −4
Open

test/e2e: fix flake in WaitForModelServingReady #876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions test/e2e/utils/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,11 @@ import (
// if all expected replicas are available.
func WaitForModelServingReady(t *testing.T, ctx context.Context, kthenaClient *clientset.Clientset, namespace, name string) {
t.Log("Waiting for ModelServing to be ready...")
timeoutCtx, cancel := context.WithTimeout(ctx, 5*time.Minute)
defer cancel()
err := wait.PollUntilContextTimeout(timeoutCtx, 5*time.Second, 5*time.Minute, true, func(ctx context.Context) (bool, error) {
err := wait.PollUntilContextTimeout(ctx, 5*time.Second, 5*time.Minute, true, func(ctx context.Context) (bool, error) {
ms, err := kthenaClient.WorkloadV1alpha1().ModelServings(namespace).Get(ctx, name, metav1.GetOptions{})
Comment on lines 32 to 35
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider calling t.Helper() at the start of this helper function so assertion failures (e.g., require.NoError below) are reported at the caller site instead of inside utils.go, which makes debugging failing e2e tests easier.

Copilot uses AI. Check for mistakes.
if err != nil {
t.Logf("Error getting ModelServing %s, retrying: %v", name, err)
return false, err
return false, nil
}
// Check if all replicas are available
expectedReplicas := int32(1)
Expand Down
Loading