Skip to content

Fix fork CI failures for GHCR owner casing and Python liccheck#835

Open
Tweakzx wants to merge 2 commits intovolcano-sh:mainfrom
Tweakzx:fix-lowercase-ghcr-owner
Open

Fix fork CI failures for GHCR owner casing and Python liccheck#835
Tweakzx wants to merge 2 commits intovolcano-sh:mainfrom
Tweakzx:fix-lowercase-ghcr-owner

Conversation

@Tweakzx
Copy link
Copy Markdown
Contributor

@Tweakzx Tweakzx commented Mar 22, 2026

Summary

  • normalize the GHCR repository owner to lowercase in the release workflow before constructing image references
  • extend the Python liccheck allowlist for SPDX identifiers/expressions reported by huggingface-hub transitive dependencies
  • keep a no-op Python Dockerfile formatting change so the PR can trigger the relevant release workflow checks

Problem

This PR addresses two CI failures discussed in #834:

  • GHCR image references fail when the repository owner contains uppercase characters
  • Python license lint fails for SPDX expressions from packaging and tqdm

Validation

  • PRs that touch python/Dockerfile should trigger Build, Push, and Release
  • GHCR image names should use lowercase owner names in workflow logs
  • Python Licenses Check should stop flagging the packaging and tqdm dependencies as unknown

Copilot AI review requested due to automatic review settings March 22, 2026 04:24
@volcano-sh-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hzxuzhonghu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses CI failures related to GHCR image references and Python license checks. It normalizes the GHCR repository owner casing and updates the Python license allowlist to resolve these issues, while also ensuring the release workflow is triggered.

Highlights

  • GHCR Owner Casing: The GHCR repository owner is now normalized to lowercase in the release workflow to prevent image reference failures.
  • Python License Check: Extended the Python license check allowlist to include SPDX identifiers/expressions reported by huggingface-hub transitive dependencies, specifically addressing issues with packaging and tqdm.
  • Dockerfile Trigger: A no-op Python Dockerfile formatting change was included to ensure the PR triggers the relevant release workflow checks.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/build-push-release.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Python license allowlist to resolve CI failures and applies a formatting change to python/Dockerfile. While reviewing the Dockerfile, I noticed that the downloader and runtime build stages contain significant duplicated logic for package and tool installation. To improve build performance and maintainability, consider refactoring this into a common base stage in a future change. This would reduce redundancy and make the Dockerfile easier to manage.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves fork-specific CI failures by ensuring GHCR image references always use a lowercase owner name and by expanding the Python liccheck allowlist to cover SPDX identifiers/expressions seen in transitive dependencies.

Changes:

  • Normalize the GitHub repository owner to lowercase once in the release workflow and reuse it for all GHCR/OCI references.
  • Extend the Python license allowlist to include SPDX forms reported by liccheck (e.g., apache-2.0, bsd-2-clause, mpl-2.0).
  • Apply a no-op formatting tweak in python/Dockerfile to ensure the release workflow is exercised.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
python/Dockerfile Minor formatting/no-op change to trigger relevant workflow checks.
config/python-licenses-lint.ini Adds additional authorized SPDX identifiers/strings to satisfy liccheck output.
.github/workflows/build-push-release.yml Introduces owner_lc output and replaces GHCR/OCI references to avoid uppercase-owner invalid image refs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LiZhenCheng9527
Copy link
Copy Markdown
Contributor

Thank you for your contrubtion.
Please use git commit -s signoff this PR.

@Tweakzx Tweakzx force-pushed the fix-lowercase-ghcr-owner branch from 152e6ca to 1f97970 Compare March 28, 2026 07:17
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the push trigger if this is the cause of failure when you push to your own main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants