Fix fork CI failures for GHCR owner casing and Python liccheck#835
Fix fork CI failures for GHCR owner casing and Python liccheck#835Tweakzx wants to merge 2 commits intovolcano-sh:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses CI failures related to GHCR image references and Python license checks. It normalizes the GHCR repository owner casing and updates the Python license allowlist to resolve these issues, while also ensuring the release workflow is triggered. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Python license allowlist to resolve CI failures and applies a formatting change to python/Dockerfile. While reviewing the Dockerfile, I noticed that the downloader and runtime build stages contain significant duplicated logic for package and tool installation. To improve build performance and maintainability, consider refactoring this into a common base stage in a future change. This would reduce redundancy and make the Dockerfile easier to manage.
There was a problem hiding this comment.
Pull request overview
This PR resolves fork-specific CI failures by ensuring GHCR image references always use a lowercase owner name and by expanding the Python liccheck allowlist to cover SPDX identifiers/expressions seen in transitive dependencies.
Changes:
- Normalize the GitHub repository owner to lowercase once in the release workflow and reuse it for all GHCR/OCI references.
- Extend the Python license allowlist to include SPDX forms reported by
liccheck(e.g.,apache-2.0,bsd-2-clause,mpl-2.0). - Apply a no-op formatting tweak in
python/Dockerfileto ensure the release workflow is exercised.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
python/Dockerfile |
Minor formatting/no-op change to trigger relevant workflow checks. |
config/python-licenses-lint.ini |
Adds additional authorized SPDX identifiers/strings to satisfy liccheck output. |
.github/workflows/build-push-release.yml |
Introduces owner_lc output and replaces GHCR/OCI references to avoid uppercase-owner invalid image refs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thank you for your contrubtion. |
Signed-off-by: lizhixuan <[email protected]>
Signed-off-by: lizhixuan <[email protected]>
152e6ca to
1f97970
Compare
hzxuzhonghu
left a comment
There was a problem hiding this comment.
Should we remove the push trigger if this is the cause of failure when you push to your own main branch
Summary
huggingface-hubtransitive dependenciesProblem
This PR addresses two CI failures discussed in #834:
packagingandtqdmValidation
python/Dockerfileshould triggerBuild, Push, and ReleasePython Licenses Checkshould stop flagging thepackagingandtqdmdependencies as unknown