Skip to content

Stop publishing Python packages from main branch pushes#271

Merged
volcano-sh-bot merged 1 commit intovolcano-sh:mainfrom
acsoto:fix/python-package-publish-triggers
Apr 14, 2026
Merged

Stop publishing Python packages from main branch pushes#271
volcano-sh-bot merged 1 commit intovolcano-sh:mainfrom
acsoto:fix/python-package-publish-triggers

Conversation

@acsoto
Copy link
Copy Markdown
Member

@acsoto acsoto commented Apr 13, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:

image

Stop publishing the Python CLI and Python SDK to PyPI on every push to main.

PyPI package versions are immutable, so triggering package publishes from regular main branch changes causes repeated failures when the package version has not been bumped. This change limits Python package publishing to release tags and manual dispatches, which matches the expected release flow more closely and avoids noisy deployment failures.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

This is a stopgap change only. It does not define the long-term Python package versioning or release policy yet.

Does this PR introduce a user-facing change?:

NONE

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@acsoto acsoto force-pushed the fix/python-package-publish-triggers branch from 0a9bbf7 to 3b3adec Compare April 13, 2026 08:14
@acsoto acsoto marked this pull request as ready for review April 13, 2026 08:15
Copilot AI review requested due to automatic review settings April 13, 2026 08:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Limits Python package publishing so it no longer runs on every push to main, reducing failures from attempting to re-publish immutable PyPI versions.

Changes:

  • Update Python SDK publish workflow to trigger on version tags and manual dispatch only.
  • Update Python CLI publish workflow to trigger on version tags and manual dispatch only.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/python-sdk-publish.yml Removes main branch/path triggers; adds tag-based triggers for publishing.
.github/workflows/python-cli-publish.yml Removes main branch/path triggers; adds tag-based triggers for publishing.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 13, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.32%. Comparing base (845b798) to head (8c6186f).
⚠️ Report is 158 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
+ Coverage   35.60%   43.32%   +7.71%     
==========================================
  Files          29       30       +1     
  Lines        2533     2613      +80     
==========================================
+ Hits          902     1132     +230     
+ Misses       1505     1358     -147     
+ Partials      126      123       -3     
Flag Coverage Δ
unittests 43.32% <ø> (+7.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Zhou Zihang <z@mcac.cc>
@acsoto acsoto force-pushed the fix/python-package-publish-triggers branch from 3b3adec to 8c6186f Compare April 13, 2026 08:33
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit 0808426 into volcano-sh:main Apr 14, 2026
14 checks passed
@acsoto acsoto deleted the fix/python-package-publish-triggers branch April 14, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants