Stop publishing Python packages from main branch pushes#271
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
0a9bbf7 to
3b3adec
Compare
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Limits Python package publishing so it no longer runs on every push to main, reducing failures from attempting to re-publish immutable PyPI versions.
Changes:
- Update Python SDK publish workflow to trigger on version tags and manual dispatch only.
- Update Python CLI publish workflow to trigger on version tags and manual dispatch only.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/python-sdk-publish.yml | Removes main branch/path triggers; adds tag-based triggers for publishing. |
| .github/workflows/python-cli-publish.yml | Removes main branch/path triggers; adds tag-based triggers for publishing. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
+ Coverage 35.60% 43.32% +7.71%
==========================================
Files 29 30 +1
Lines 2533 2613 +80
==========================================
+ Hits 902 1132 +230
+ Misses 1505 1358 -147
+ Partials 126 123 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Zhou Zihang <z@mcac.cc>
3b3adec to
8c6186f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Stop publishing the Python CLI and Python SDK to PyPI on every push to
main.PyPI package versions are immutable, so triggering package publishes from regular
mainbranch changes causes repeated failures when the package version has not been bumped. This change limits Python package publishing to release tags and manual dispatches, which matches the expected release flow more closely and avoids noisy deployment failures.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is a stopgap change only. It does not define the long-term Python package versioning or release policy yet.
Does this PR introduce a user-facing change?: