Skip to content

fix: stop codeinterpreter controller from spamming status updates #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sanchit2662 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: stop codeinterpreter controller from spamming status updates #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2d5eaf
fix: stop codeinterpreter controller from spamming status updates
Sanchit2662 Apr 8, 2026
57f6d84
fix: skip status update when CodeInterpreter condition unchanged
Sanchit2662 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions cmd/workload-manager/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,8 @@ func setupControllers(mgr ctrl.Manager, sandboxReconciler *workloadmanager.Sandb
return fmt.Errorf("unable to create sandbox controller: %w", err)
}

// Setup CodeInterpreter controller
if err := ctrl.NewControllerManagedBy(mgr).
For(&runtimev1alpha1.CodeInterpreter{}).
Complete(codeInterpreterReconciler); err != nil {
// Setup CodeInterpreter controller.
if err := codeInterpreterReconciler.SetupWithManager(mgr); err != nil {
return fmt.Errorf("unable to create codeinterpreter controller: %w", err)
}

Expand Down
45 changes: 22 additions & 23 deletions pkg/workloadmanager/codeinterpreter_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,16 @@ import (

corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
apimeta "k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/builder"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/predicate"

runtimev1alpha1 "github.com/volcano-sh/agentcube/pkg/apis/runtime/v1alpha1"
sandboxv1alpha1 "sigs.k8s.io/agent-sandbox/api/v1alpha1"
Expand Down Expand Up @@ -95,35 +98,29 @@ func (r *CodeInterpreterReconciler) Reconcile(ctx context.Context, req ctrl.Requ
return ctrl.Result{}, nil
}

// updateStatus updates the CodeInterpreter status
// updateStatus updates the CodeInterpreter status. It skips the API write
// when the status is already up-to-date to avoid triggering a new watch event
// that would re-enqueue the object unnecessarily.
func (r *CodeInterpreterReconciler) updateStatus(ctx context.Context, ci *runtimev1alpha1.CodeInterpreter) error {
// Update status
ci.Status.Ready = true
existing := apimeta.FindStatusCondition(ci.Status.Conditions, "Ready")
if ci.Status.Ready &&
existing != nil &&
existing.Status == metav1.ConditionTrue &&
existing.ObservedGeneration == ci.Generation {
return nil
}

// Update conditions
readyCondition := metav1.Condition{
ci.Status.Ready = true
// SetStatusCondition only updates LastTransitionTime when the condition
// Status actually changes, preventing spurious status writes that would
// trigger an infinite reconciliation loop.
apimeta.SetStatusCondition(&ci.Status.Conditions, metav1.Condition{
Type: "Ready",
Status: metav1.ConditionTrue,
Reason: "Reconciled",
Message: "CodeInterpreter is ready",
LastTransitionTime: metav1.Now(),
ObservedGeneration: ci.Generation,
}

// Update or add condition
conditionIndex := -1
for i, cond := range ci.Status.Conditions {
if cond.Type == "Ready" {
conditionIndex = i
break
}
}

if conditionIndex >= 0 {
ci.Status.Conditions[conditionIndex] = readyCondition
} else {
ci.Status.Conditions = append(ci.Status.Conditions, readyCondition)
}
})
Comment on lines +114 to +123
Copy link
Copy Markdown
Member

@acsoto acsoto Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method still calls Status().Update() on every reconcile? It would be safer to skip the status update when nothing actually changed.


return r.Status().Update(ctx, ci)
}
Expand Down Expand Up @@ -361,10 +358,12 @@ func (r *CodeInterpreterReconciler) GetCodeInterpreter(name, namespace string) *
}

// SetupWithManager sets up the controller with the Manager.
// GenerationChangedPredicate filters out status-only update events so that
// the controller is not re-enqueued by its own status writes.
func (r *CodeInterpreterReconciler) SetupWithManager(mgr ctrl.Manager) error {
r.mgr = mgr

return ctrl.NewControllerManagedBy(mgr).
For(&runtimev1alpha1.CodeInterpreter{}).
For(&runtimev1alpha1.CodeInterpreter{}, builder.WithPredicates(predicate.GenerationChangedPredicate{})).
Complete(r)
}
Loading