Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the version of the agentcube-sdk package from 0.1.0 to 0.1.1 in the pyproject.toml file. The review feedback suggests enhancing the package metadata by adding authors and classifiers to improve its discoverability on PyPI, and also recommends considering dynamic versioning for more robust release management.
sdk-python/pyproject.toml
Outdated
| [project] | ||
| name = "agentcube-sdk" | ||
| version = "0.1.0" | ||
| version = "0.1.1" |
There was a problem hiding this comment.
Since this version bump is intended for a PyPI release, it is highly recommended to include additional metadata in the [project] section. Fields such as authors and classifiers improve the package's discoverability and provide essential information to users on PyPI. Additionally, for automated release workflows, consider using dynamic versioning (e.g., setuptools-scm) to keep the version in sync with git tags, ensuring the package version always matches the repository state.
version = "0.1.1"
authors = [
{ name = "Volcano Authors" }
]
classifiers = [
"Programming Language :: Python :: 3",
"License :: OSI Approved :: Apache Software License",
"Operating System :: OS Independent",
]
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 35.60% 43.32% +7.71%
==========================================
Files 29 30 +1
Lines 2533 2613 +80
==========================================
+ Hits 902 1132 +230
+ Misses 1505 1358 -147
+ Partials 126 123 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
If this is for testing purposes, could we add a suffix? It would be better for the version 0.1.1 to follow the version number of the AgentCube itself? |
LiZhenCheng9527
force-pushed
the
python-sdk
branch
from
7286e46 to
bd9937b
Compare
|
New changes are detected. LGTM label has been removed. |
Done |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
LiZhenCheng9527
force-pushed
the
python-sdk
branch
from
bd9937b to
124351f
Compare
Signed-off-by: LiZhenCheng9527 <[email protected]>
LiZhenCheng9527
force-pushed
the
python-sdk
branch
from
124351f to
a40a79b
Compare
| [project] | ||
| name = "agentcube-sdk" | ||
| version = "0.1.0" | ||
| version = "0.1.1.dev0" |
There was a problem hiding this comment.
| version = "0.1.1.dev0" | |
| version = "0.1-dev" |
There was a problem hiding this comment.
We now have agentcube-sdk 0.1.0. If a new release is made with the SDK as 0.1-dev, it might lead people to think that 0.1.0 is the latest version, which is misleading.
There was a problem hiding this comment.
we need to re push 0.1.0, previous one is not right
What type of PR is this?
What this PR does / why we need it:
update python-sdk project version in pyproject.toml to auto push new python sdk version to pypi
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: