Remove comment of find library for windows if needed#1512
Remove comment of find library for windows if needed#1512j-t-1 wants to merge 1 commit intovolatilityfoundation:developfrom j-t-1:TODO
Conversation
The Windows library has previously been added to the try block.
|
I don't know that this works under windows, I haven't tried it? The FIXME is there to get me to check it? If you've checked that it works under windows, then I'll take it out happily, but otherwise we need to check it at somepoint (and having a FIXME there is a useful reminder). |
|
Have not run this under Windows. Was thinking (probably wrongly) that the comment was referring to lines 37 and 43. I think the comment could be changed to make it more self-explanatory. |
|
No, you're right, those are the lines it's referring to, I just... never actually tested them. 5:P As soon as someone's confirmed that they've checked it all works right on windows, I'm happy to ditch the FIXME... 5:D |
Installing python-snappy 0.7.3 on Windows and then trying So for Snappy to work on Windows you need to compile from source? I do not know if this is correct, so gonna close this. |
The Windows library has previously been added to the try block.