feat(sigsafe): iterate process arguments and environment - #625
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
fspy benchmarklinuxmacoswindows |
wan9chi
force-pushed
the
feat/sigsafe-process-env
branch
from
August 10, 2026 04:50
1a173a3 to
873df3b
Compare
wan9chi
force-pushed
the
feat/sigsafe-process-env
branch
7 times, most recently
from
August 10, 2026 08:47
21f7ece to
9473edf
Compare
wan9chi
marked this pull request as ready for review
August 10, 2026 08:51
Co-authored-by: GPT-5 Codex <codex@openai.com>
wan9chi
force-pushed
the
feat/sigsafe-process-env
branch
from
August 10, 2026 08:55
9473edf to
00deef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Low-level fspy code needs allocation-free access to the current process arguments and environment. On Linux, that access must also avoid libc so it remains suitable for injected and signal-sensitive code.
This adds a shared
current()API that snapshots argument and environment bounds together. Linux obtains both ranges from one/proc/self/statread and iterates their memory directly. macOS exposes direct thin iterators backed by_NSGetArgvand_NSGetEnviron, then builds the portable fatcurrent()view only from those thin APIs.The Unix preload ctor obtains one
Currentsnapshot and passescurrent.envs()throughClient::from_envtodecode_payload_from_env. The payload helper retains its existing name while accepting the environment iterator explicitly, so payload initialization avoidsstd::env. Exec wrappers retain their existing environment inheritance andPATHbehavior.Stack created with GitHub Stacks CLI • Give Feedback 💬