feat(sigsafe): add thin C string byte iteration - #624
Merged
Conversation
fspy benchmarklinuxmacoswindows |
wan9chi
force-pushed
the
feat/sigsafe-cstr-bytes
branch
from
August 10, 2026 04:50
c9367b4 to
4e0d3aa
Compare
wan9chi
marked this pull request as ready for review
August 10, 2026 08:51
Co-authored-by: GPT-5 Codex <codex@openai.com>
wan9chi
force-pushed
the
feat/sigsafe-cstr-bytes
branch
from
August 10, 2026 08:55
4e0d3aa to
d22b75a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Thin C strings currently expose only a raw-pointer constructor and a whole-string count operation. Allocation-free callers that need to inspect bytes must duplicate unsafe NUL scanning, and callers that have already checked pointer nullability cannot preserve that proof.
This adds
CStr<Thin>::bytes()and a reusable fused byte iterator, plusfrom_non_nullso checked pointers stay non-null through construction.from_ptrremains as the unchecked raw-pointer adapter, andcountreuses the byte iterator.Stack created with GitHub Stacks CLI • Give Feedback 💬