Skip to content

refactor(fspy): type intercepted paths - #618

Merged
wan9chi merged 1 commit into
agent/extract-sigsafe-allocfrom
agent/sigsafe-cstr-fd
Aug 9, 2026
Merged

refactor(fspy): type intercepted paths#618
wan9chi merged 1 commit into
agent/extract-sigsafe-allocfrom
agent/sigsafe-cstr-fd

Conversation

@wan9chi

@wan9chi wan9chi commented Aug 9, 2026

Copy link
Copy Markdown
Member

Motivation

Preload path arguments enter as raw ABI values, while the later signal-safe filesystem work needs borrowed, typed inputs. Introduce the minimal sigsafe::CStr<Thin> representation, expose rustix's borrowed descriptor types, and convert raw descriptors and path pointers at the interception boundary. This makes ToAbsolutePath safe without introducing length metadata, allocation, or filesystem APIs early.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

fspy benchmark

linux

dynamic/launch             change  +1.18%  [ -3.66% ..  +7.02%]  overhead   +53.78%
dynamic/access             change  -0.26%  [-12.18% .. +15.18%]  overhead    +7.01%
dynamic/access-relative    change  +0.00%  [-11.39% ..  +2.82%]  overhead   +54.81%
static/launch              change  +1.41%  [ -6.33% .. +11.84%]  overhead  +150.96%
static/access              change  +0.14%  [ -3.38% ..  +6.77%]  overhead  +861.28%
static/access-relative     change  -0.74%  [ -5.06% ..  +2.70%]  overhead +1168.49%

macos

dynamic/launch             change  -0.44%  [ -5.41% ..  +5.74%]  overhead  +237.87%
dynamic/access             change  +0.32%  [ -6.76% ..  +4.17%]  overhead    +1.69%
dynamic/access-relative    change  -0.45%  [ -6.07% ..  +6.35%]  overhead  +372.92%

windows

dynamic/launch             change  +0.29%  [ -3.31% ..  +3.34%]  overhead   +28.71%
dynamic/access             change  +0.00%  [ -1.08% ..  +1.12%]  overhead    +1.15%
dynamic/access-relative    change  +0.19%  [ -0.90% ..  +1.14%]  overhead    +1.52%

@wan9chi
wan9chi force-pushed the agent/sigsafe-cstr-fd branch from c4c10a7 to 96bd245 Compare August 9, 2026 12:28
Co-authored-by: GPT-5 Codex <codex@openai.com>
@wan9chi
wan9chi force-pushed the agent/sigsafe-cstr-fd branch from 96bd245 to 198c947 Compare August 9, 2026 15:46
@wan9chi wan9chi changed the title refactor(fspy): type descriptor-relative paths refactor(fspy): type intercepted paths Aug 9, 2026
@wan9chi
wan9chi marked this pull request as ready for review August 9, 2026 16:40
@wan9chi
wan9chi merged commit e6b875b into main Aug 9, 2026
19 checks passed
@wan9chi
wan9chi deleted the agent/sigsafe-cstr-fd branch August 9, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant