refactor(fspy): retain C string lengths in path resolution - #616
Merged
Conversation
fspy benchmarklinuxmacoswindows |
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
2 times, most recently
from
August 9, 2026 11:50
2b371d5 to
d11b23e
Compare
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
from
August 9, 2026 11:59
d11b23e to
eaa4ad5
Compare
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
2 times, most recently
from
August 9, 2026 12:18
264c83c to
57d22a2
Compare
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
2 times, most recently
from
August 9, 2026 12:34
f75f819 to
cf125de
Compare
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
from
August 9, 2026 12:41
cf125de to
8f3e7e6
Compare
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
2 times, most recently
from
August 9, 2026 13:00
16d1b86 to
ecf1426
Compare
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
from
August 9, 2026 13:03
ecf1426 to
3421475
Compare
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
from
August 9, 2026 13:28
3421475 to
547b9f2
Compare
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
from
August 9, 2026 13:36
547b9f2 to
5ccdaf5
Compare
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
from
August 9, 2026 14:08
5ccdaf5 to
91477d9
Compare
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
from
August 9, 2026 14:09
91477d9 to
8f16499
Compare
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
2 times, most recently
from
August 9, 2026 15:21
e668a24 to
ba4ac92
Compare
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
2 times, most recently
from
August 9, 2026 15:38
38c23e9 to
3b35d81
Compare
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
from
August 9, 2026 15:46
3b35d81 to
14d6316
Compare
Co-authored-by: GPT-5 Codex <codex@openai.com>
wan9chi
force-pushed
the
agent/sigsafe-cstr-paths
branch
from
August 9, 2026 16:26
14d6316 to
6f47415
Compare
wan9chi
marked this pull request as ready for review
August 9, 2026 16:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Path resolution currently converts
sigsafe::CStr<Thin>back intocore::ffi::CStr, so its terminator scan produces only a temporary slice. Count intosigsafe::CStr<Fat>, expose its bytes without the terminator, and use that retained length while resolving paths.This keeps the callback and allocation behavior unchanged so the following PR can review the output-ownership change independently.