refactor(fspy): return resolved paths without callbacks - #607
Merged
Conversation
fspy benchmarklinuxmacoswindows |
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
16 times, most recently
from
August 9, 2026 11:05
7c259c6 to
d676f77
Compare
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
from
August 9, 2026 11:26
d676f77 to
6149e3a
Compare
wan9chi
changed the base branch from
agent/extract-sigsafe-alloc
to
agent/sigsafe-cstr-paths
August 9, 2026 11:29
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
from
August 9, 2026 11:37
6149e3a to
74fbd2d
Compare
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
2 times, most recently
from
August 9, 2026 11:59
341c727 to
f4b901d
Compare
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
from
August 9, 2026 12:04
f4b901d to
d312055
Compare
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
from
August 9, 2026 13:03
08b8519 to
959ba48
Compare
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
from
August 9, 2026 13:28
959ba48 to
439c770
Compare
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
from
August 9, 2026 13:36
439c770 to
3e03ebf
Compare
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
2 times, most recently
from
August 9, 2026 14:09
f5d66b3 to
c92665e
Compare
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
from
August 9, 2026 14:46
c92665e to
965bc90
Compare
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
from
August 9, 2026 15:21
965bc90 to
2c739d4
Compare
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
2 times, most recently
from
August 9, 2026 15:38
2639a29 to
cf8c38c
Compare
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
5 times, most recently
from
August 9, 2026 16:03
32b29b5 to
dc7a94e
Compare
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
from
August 9, 2026 16:26
dc7a94e to
8846fa8
Compare
Co-authored-by: GPT-5 Codex <codex@openai.com>
wan9chi
force-pushed
the
agent/sigsafe-fs-wrappers
branch
from
August 9, 2026 16:39
8846fa8 to
9370275
Compare
wan9chi
marked this pull request as ready for review
August 9, 2026 16:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
to_absolute_pathstill exposes each resolved path through a callback even though every intercepted call can provide a signal-safe arena. Accept that allocator directly and return the resolved path instead.The return type is
sigsafe::CStr<Fat>rather than a plainBStr, becauseexecveatforwards the result to a real exec, which needs a terminator. Carrying that in the type means an implementation cannot hand the exec unterminated bytes; callers wanting the path without the NUL useas_bytes.Descriptor resolution continues to produce a vector, so relative pathnames and the trailing NUL are appended to that same storage before it is left in the arena. Already-absolute inputs return their original C string with no allocation at all.
execveatresolves once and makes onehandle_execcall.