feat: allow comments (JSONC) in vite-task.json - #139
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
approved these changes
Feb 5, 2026
Use jsonc-parser to parse vite-task.json, enabling // line comments, /* */ block comments, and trailing commas. Add comments to several test fixture files to exercise this. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
JsonUserConfigLoader is only instantiated in vite_task_bin, so it belongs there rather than in the core graph crate. This also removes the tokio dependency from vite_task_graph. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
wan9chi
force-pushed
the
02-05-test_add_comments_in_vite-task.json
branch
from
February 5, 2026 06:38
938ea44 to
4a56d3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for JSONC comments in vite-task.json
Use jsonc-parser to parse vite-task.json, enabling
//line comments,/* */block comments, and trailing commas. Add comments to severaltest fixture files to exercise this.
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com