fix(cache): forward cache command to local CLI and update cache path - #427
Merged
Merged
Conversation
fengmk2
marked this pull request as ready for review
January 14, 2026 11:52
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the cache command forwarding in the global CLI and updates the task cache storage path. The cache command can now be invoked from the global CLI (forwarding to local CLI), and the cache is stored in a more standard location within node_modules/.vite/task-cache instead of .vite-plus.
Changes:
- Added 'cache' to the list of commands forwarded from global to local CLI
- Updated task cache path from
.vite-plustonode_modules/.vite/task-cache - Updated cache-clean snap test to use
vite fmtinstead ofecho helloto properly test caching behavior
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/global/src/index.ts | Added 'cache' to LOCAL_CLI_COMMANDS array to enable cache command forwarding |
| packages/cli/snap-tests/cache-clean/src/index.ts | Added source file for cache-clean snap test |
| packages/cli/snap-tests/cache-clean/snap.txt | Updated expected output to reflect vite fmt command instead of echo hello |
| packages/cli/snap-tests/cache-clean/package.json | Changed hello script from echo hello to vite fmt |
| packages/cli/binding/src/cli.rs | Updated cache path from .vite-plus to node_modules/.vite/task-cache |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wan9chi
approved these changes
Jan 14, 2026
- Add 'cache' to LOCAL_CLI_COMMANDS in global CLI to forward to local CLI - Change task cache path from `.vite-plus` to `node_modules/.vite/task-cache` - Update cache-clean snap test to use `vite fmt` instead of `echo hello` Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
fengmk2
force-pushed
the
fix-cache-command
branch
from
January 14, 2026 14:08
1b0201b to
395f7f4
Compare
Member
Author
Member
Author
|
Why can it automatically merge even if the CI failed?😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.vite-plustonode_modules/.vite/task-cachevite fmtinstead ofecho helloCo-Authored-By: Claude Opus 4.5 noreply@anthropic.com