build(core): split native packages publishing - #419
Conversation
e7206fe to
3adfd7e
Compare
Deploying vite-plus with
|
| Latest commit: |
4a237d1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fcdd04de.vite-plus.pages.dev |
| Branch Preview URL: | https://01-13-build-core-split-nativ.vite-plus.pages.dev |
c23b456 to
6b967ca
Compare
d8b70c8 to
2da328e
Compare
e308538 to
3f12293
Compare
3f12293 to
4a237d1
Compare
|
Cool, everything pass! |
There was a problem hiding this comment.
Pull request overview
This PR restructures the native package publishing strategy by splitting native addon publishing into a separate step. It updates dependencies (oxc packages from 0.107.0 to 0.108.0), migrates the CLI binding from ESM to CJS format, and streamlines the build/release workflow by removing redundant rolldown build steps.
Changes:
- Updates oxc-related dependencies to version 0.108.0 and other tooling dependencies
- Implements separate native package publishing workflow with new
publish-native-addons.tsscript - Migrates CLI bindings from ESM (
index.js) to CommonJS (index.cjs) format
Reviewed changes
Copilot reviewed 31 out of 35 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain.toml | Updates Rust nightly toolchain version |
| pnpm-workspace.yaml / pnpm-lock.yaml | Updates oxc and related package versions |
| packages/cli/publish-native-addons.ts | New script to handle native addon publishing |
| packages/cli/package.json | Updates package name and exports configuration |
| packages/cli/binding/* | Migrates from ESM to CJS, updates generated binding code |
| packages/core/build.ts | Adds rolldown binding version management |
| .github/workflows/release.yml | Adds native package publishing step |
| Cargo.toml | Adds extensive rolldown and oxc workspace dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a237d1f40
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Merge activity
|

Note
Brings the rolldown toolchain into the repository and aligns builds with prebuilt binaries to simplify CI and releases.
rolldown_*andoxc*crates to[workspace.dependencies], sets required[workspace.package]fields, bumpsrust-version, and configures.cargo/config.toml(envWORKSPACE_DIR,bindeps, git CLI fetch)rolldownfeature viarolldown_binding, updates.gitignore, and enables tokio test utilities forvite_commandbuild-upstreamconsumes them and enablesDEBUG=napi:*; CI pipelines updated to download artifacts, limit cargo test scope, and quiet rustdoc; release workflow uploads native addons and uses the download action; dependency-upgrade workflow builds with the new actionWritten by Cursor Bugbot for commit 4a237d1. This will update automatically on new commits. Configure here.