Skip to content

build(core): split native packages publishing - #419

Merged
Brooooooklyn merged 1 commit into
mainfrom
01-13-build_core_split_native_packages_publishing
Jan 15, 2026
Merged

Brooooooklyn merged 1 commit into
mainfrom
01-13-build_core_split_native_packages_publishing

Conversation

@Brooooooklyn

@Brooooooklyn Brooooooklyn commented Jan 14, 2026

Copy link
Copy Markdown
Member

Note

Brings the rolldown toolchain into the repository and aligns builds with prebuilt binaries to simplify CI and releases.

  • Adds extensive rolldown_* and oxc* crates to [workspace.dependencies], sets required [workspace.package] fields, bumps rust-version, and configures .cargo/config.toml (env WORKSPACE_DIR, bindeps, git CLI fetch)
  • CLI: introduces optional rolldown feature via rolldown_binding, updates .gitignore, and enables tokio test utilities for vite_command
  • CI: new composite action to download previous rolldown binaries; build-upstream consumes them and enables DEBUG=napi:*; CI pipelines updated to download artifacts, limit cargo test scope, and quiet rustdoc; release workflow uploads native addons and uses the download action; dependency-upgrade workflow builds with the new action
  • Docs: minor formatting in VitePress config
  • Cargo.lock: large dependency sync to include rolldown/oxc stacks

Written by Cursor Bugbot for commit 4a237d1. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Brooooooklyn
Brooooooklyn force-pushed the 01-13-build_core_split_native_packages_publishing branch from e7206fe to 3adfd7e Compare January 14, 2026 03:53
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jan 14, 2026

Copy link
Copy Markdown

Deploying vite-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4a237d1
Status: ✅  Deploy successful!
Preview URL: https://fcdd04de.vite-plus.pages.dev
Branch Preview URL: https://01-13-build-core-split-nativ.vite-plus.pages.dev

View logs

@Brooooooklyn
Brooooooklyn force-pushed the 01-13-build_core_split_native_packages_publishing branch 13 times, most recently from c23b456 to 6b967ca Compare January 14, 2026 10:49
@Brooooooklyn Brooooooklyn added the test: e2e Auto run e2e tests label Jan 14, 2026
@Brooooooklyn
Brooooooklyn force-pushed the 01-13-build_core_split_native_packages_publishing branch 12 times, most recently from d8b70c8 to 2da328e Compare January 14, 2026 14:08
@Brooooooklyn
Brooooooklyn force-pushed the 01-13-build_core_split_native_packages_publishing branch 4 times, most recently from e308538 to 3f12293 Compare January 14, 2026 14:57
@Brooooooklyn
Brooooooklyn force-pushed the 01-13-build_core_split_native_packages_publishing branch from 3f12293 to 4a237d1 Compare January 14, 2026 15:25
@fengmk2

fengmk2 commented Jan 15, 2026

Copy link
Copy Markdown
Member

Cool, everything pass!

@Brooooooklyn
Brooooooklyn marked this pull request as ready for review January 15, 2026 02:32
Copilot AI review requested due to automatic review settings January 15, 2026 02:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restructures the native package publishing strategy by splitting native addon publishing into a separate step. It updates dependencies (oxc packages from 0.107.0 to 0.108.0), migrates the CLI binding from ESM to CJS format, and streamlines the build/release workflow by removing redundant rolldown build steps.

Changes:

  • Updates oxc-related dependencies to version 0.108.0 and other tooling dependencies
  • Implements separate native package publishing workflow with new publish-native-addons.ts script
  • Migrates CLI bindings from ESM (index.js) to CommonJS (index.cjs) format

Reviewed changes

Copilot reviewed 31 out of 35 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
rust-toolchain.toml Updates Rust nightly toolchain version
pnpm-workspace.yaml / pnpm-lock.yaml Updates oxc and related package versions
packages/cli/publish-native-addons.ts New script to handle native addon publishing
packages/cli/package.json Updates package name and exports configuration
packages/cli/binding/* Migrates from ESM to CJS, updates generated binding code
packages/core/build.ts Adds rolldown binding version management
.github/workflows/release.yml Adds native package publishing step
Cargo.toml Adds extensive rolldown and oxc workspace dependencies
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/cli/binding/Cargo.toml
Comment thread packages/core/build.ts
Comment thread .github/workflows/ci.yml
Comment thread packages/cli/binding/index.cjs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4a237d1f40

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/actions/download-rolldown-binaries/action.yml
@Brooooooklyn
Brooooooklyn merged commit b10afab into main Jan 15, 2026
40 checks passed

Copy link
Copy Markdown
Member Author

Merge activity

@Brooooooklyn
Brooooooklyn deleted the 01-13-build_core_split_native_packages_publishing branch January 15, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: e2e Auto run e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants