fix(core): add picomatch - #388
Merged
Merged
Conversation
fengmk2
approved these changes
Jan 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds picomatch as a dependency to the core package to support bundling needs. The picomatch library is used for glob pattern matching and is referenced in the build configuration where it's excluded from external dependencies, indicating it should be bundled with the application.
Key Changes
- Added picomatch ^4.0.3 as a dependency in packages/core/package.json
- Updated pnpm-lock.yaml to reflect the new dependency
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/package.json | Added picomatch ^4.0.3 to dependencies section |
| pnpm-lock.yaml | Added corresponding lock file entry for picomatch 4.0.3 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Introduces
picomatchas a runtime dependency in core and updates the lockfile accordingly.picomatch@^4.0.3topackages/core/package.jsondependenciespnpm-lock.yamlto includepicomatchWritten by Cursor Bugbot for commit cb878c2. This will update automatically on new commits. Configure here.