feat(deps): upgrade upstream dependencies - #384
Brooooooklyn wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This is an automated daily dependency upgrade PR that updates various upstream dependencies including rolldown, rolldown-vite, vitest, and tsdown. The build has succeeded, indicating the changes are functionally compatible.
Key changes:
- Updated multiple catalog dependencies including oxc-related packages (0.101.0 → 0.106.0), vitest packages (4.0.15 → 4.0.16 for most), and various other minor version bumps
- Updated rolldown and rolldown-vite git hashes in .upstream-versions.json
- Added new export path
./rolldown/getLogFilterand replaced./libexport with./rolldown/pluginutils/filterin packages/core/package.json - Relaxed @vitejs/devtools peer dependency constraint from specific alpha version to wildcard
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates catalog versions for multiple dependencies (oxc-project, @types/node, fs-extra, mocha, vitest, etc.), adds acorn-import-assertions, and adds quotes to override values |
| packages/tools/.upstream-versions.json | Updates git commit hashes for rolldown and rolldown-vite upstream repositories |
| packages/test/package.json | Updates @vitest/* packages from 4.0.15 to 4.0.16 and vitest-dev from 4.0.15 to 4.0.16 |
| packages/core/package.json | Adds new export paths for rolldown utilities, relaxes @vitejs/devtools peer dependency to wildcard, and adds @vitejs/devtools as dev dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| vitepress-plugin-group-icons: ^1.0.0 | ||
| vitepress-plugin-llms: ^1.1.0 | ||
| vitest: ^4.0.1 | ||
| vitest: ^4.0.15 |
There was a problem hiding this comment.
The vitest catalog version is set to 4.0.15, but the vitest-dev override at line 159 uses 4.0.16, and the @vitest/ui peerDependency in packages/test/package.json (line 266) was also updated to 4.0.16. This version inconsistency could lead to unexpected behavior. The catalog version should be updated to match the other vitest-related packages at version 4.0.16.
| vitest: ^4.0.15 | |
| vitest: ^4.0.16 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "types": "./dist/tsdown/index-types.d.ts" | ||
| "./rolldown/pluginutils/filter": { | ||
| "default": "./dist/pluginutils/filter/index.js", | ||
| "types": "./dist/pluginutils/filter/index.d.ts" |
There was a problem hiding this comment.
Removed export breaks existing internal imports
The ./lib export from @voidzero-dev/vite-plus-core is being removed from the package exports map, but this export is actively used by multiple files in packages/cli/src/: lib.ts re-exports from it, lib-bin.ts imports build, UserConfig, and globalLogger from it, and index.ts imports the defineConfig type from it. Removing this export will cause these imports to fail to resolve.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 909313d53e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "./rolldown/pluginutils/filter": { | ||
| "default": "./dist/pluginutils/filter/index.js", | ||
| "types": "./dist/pluginutils/filter/index.d.ts" | ||
| }, |
There was a problem hiding this comment.
The exports map no longer exposes the ./lib subpath (it was present before this commit and was replaced with ./rolldown/pluginutils/filter). The CLI package still imports @voidzero-dev/vite-plus-core/lib (e.g., packages/cli/src/lib.ts and packages/cli/src/lib-bin.ts), so Node’s package exports resolution will now throw ERR_PACKAGE_PATH_NOT_EXPORTED when running the CLI or any consumer that relies on the lib entry point. Please reinstate the ./lib export or update the dependents to a new path.
Useful? React with 👍 / 👎.
| "default": "./dist/pluginutils/index.js", | ||
| "types": "./dist/pluginutils/index.d.ts" | ||
| }, | ||
| "./lib": { |
Automated daily upgrade of upstream dependencies:
Build status: success
Note
Introduces new Rolldown exports and upgrades test/dev tooling.
./rolldown/getLogFilterand./rolldown/pluginutils/filterexports; relaxes@vitejs/devtoolspeer range to*and adds dev dep@vitejs/devtools@^0.0.0-alpha.22.@vitest/uipeer) to4.0.16.rolldownandrolldown-vite.Written by Cursor Bugbot for commit 909313d. This will update automatically on new commits. Configure here.