-
Notifications
You must be signed in to change notification settings - Fork 262
feat(cli): replace vite-lib config with direct tsdown integration #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 0 additions & 4 deletions
4
packages/cli/snap-tests/command-lib-monorepo/packages/hello/tsdown.config.ts
This file was deleted.
Oops, something went wrong.
6 changes: 6 additions & 0 deletions
6
packages/cli/snap-tests/command-lib-monorepo/packages/hello/vite.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| export default { | ||
| lib: { | ||
| entry: 'src/index.ts', | ||
| format: ['cjs'], | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| #!/usr/bin/env node | ||
| import module from 'node:module'; | ||
|
|
||
| import { resolveConfig } from '@voidzero-dev/vite-plus-core'; | ||
| import { build, type UserConfig, globalLogger } from '@voidzero-dev/vite-plus-core/lib'; | ||
| import { cac } from 'cac'; | ||
|
|
||
| const cli = cac('vite lib'); | ||
| cli.help(); | ||
|
|
||
| const DEFAULT_ENV_PREFIXES = ['VITE_LIB_', 'TSDOWN_']; | ||
|
|
||
| cli | ||
| .command('[...files]', 'Bundle files', { | ||
| ignoreOptionDefaultValue: true, | ||
| allowUnknownOptions: true, | ||
| }) | ||
| // Only support config file in vite.config.ts | ||
| // .option('-c, --config <filename>', 'Use a custom config file') | ||
| .option('--config-loader <loader>', 'Config loader to use: auto, native, unrun', { | ||
| default: 'auto', | ||
| }) | ||
|
fengmk2 marked this conversation as resolved.
|
||
| .option('--no-config', 'Disable config file') | ||
| .option('-f, --format <format>', 'Bundle format: esm, cjs, iife, umd', { | ||
| default: 'esm', | ||
| }) | ||
| .option('--clean', 'Clean output directory, --no-clean to disable') | ||
| .option('--external <module>', 'Mark dependencies as external') | ||
| .option('--minify', 'Minify output') | ||
| .option('--devtools', 'Enable devtools integration') | ||
| .option('--debug [feat]', 'Show debug logs') | ||
| .option('--target <target>', 'Bundle target, e.g "es2015", "esnext"') | ||
| .option('-l, --logLevel <level>', 'Set log level: info, warn, error, silent') | ||
| .option('--fail-on-warn', 'Fail on warnings', { default: true }) | ||
| .option('--no-write', 'Disable writing files to disk, incompatible with watch mode') | ||
| .option('-d, --out-dir <dir>', 'Output directory', { default: 'dist' }) | ||
| .option('--treeshake', 'Tree-shake bundle', { default: true }) | ||
| .option('--sourcemap', 'Generate source map', { default: false }) | ||
| .option('--shims', 'Enable cjs and esm shims', { default: false }) | ||
| .option('--platform <platform>', 'Target platform', { | ||
| default: 'node', | ||
| }) | ||
| .option('--dts', 'Generate dts files') | ||
| .option('--publint', 'Enable publint', { default: false }) | ||
| .option('--attw', 'Enable Are the types wrong integration', { | ||
| default: false, | ||
| }) | ||
| .option('--unused', 'Enable unused dependencies check', { default: false }) | ||
| .option('-w, --watch [path]', 'Watch mode') | ||
| .option('--ignore-watch <path>', 'Ignore custom paths in watch mode') | ||
| .option('--from-vite [vitest]', 'Reuse config from Vite or Vitest') | ||
| .option('--report', 'Size report', { default: true }) | ||
| .option('--env.* <value>', 'Define compile-time env variables') | ||
| .option( | ||
| '--env-file <file>', | ||
| 'Load environment variables from a file, when used together with --env, variables in --env take precedence', | ||
| ) | ||
| .option('--env-prefix <prefix>', 'Prefix for env variables to inject into the bundle', { | ||
| // support `TSDOWN_` for migration compatibility | ||
| default: DEFAULT_ENV_PREFIXES, | ||
| }) | ||
|
fengmk2 marked this conversation as resolved.
|
||
| .option('--on-success <command>', 'Command to run on success') | ||
| .option('--copy <dir>', 'Copy files to output dir') | ||
| .option('--public-dir <dir>', 'Alias for --copy, deprecated') | ||
| .option('--tsconfig <tsconfig>', 'Set tsconfig path') | ||
| .option('--unbundle', 'Unbundle mode') | ||
| .option('-W, --workspace [dir]', 'Enable workspace mode') | ||
| .option('-F, --filter <pattern>', 'Filter configs (cwd or name), e.g. /pkg-name$/ or pkg-name') | ||
| .option('--exports', 'Generate export-related metadata for package.json (experimental)') | ||
| .action(async (input: string[], flags: UserConfig) => { | ||
| const viteConfig = await resolveConfig({ root: process.cwd() }, 'build'); | ||
| if (input.length > 0) flags.entry = input; | ||
| // TODO: set default envPrefix after tsdown upgrade | ||
| await build({ | ||
| ...(viteConfig.lib as UserConfig), | ||
|
fengmk2 marked this conversation as resolved.
|
||
| ...flags, | ||
| config: false, | ||
|
fengmk2 marked this conversation as resolved.
|
||
| }); | ||
| }); | ||
|
|
||
| export async function runCLI(): Promise<void> { | ||
| cli.parse(process.argv, { run: false }); | ||
|
|
||
| // TODO: enable debug after tsdown upgrade | ||
| // enableDebug(cli.options) | ||
|
fengmk2 marked this conversation as resolved.
|
||
|
|
||
| try { | ||
| await cli.runMatchedCommand(); | ||
| } catch (error: any) { | ||
| globalLogger.error(String(error.stack || error.message)); | ||
|
fengmk2 marked this conversation as resolved.
|
||
| process.exit(1); | ||
| } | ||
| } | ||
|
|
||
| if (module.enableCompileCache) { | ||
| module.enableCompileCache(); | ||
| } | ||
| runCLI(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.