Skip to content

fix(pm): respect filters for recursive removal on Yarn Berry - #2712

Merged
fengmk2 merged 5 commits into
voidzero-dev:mainfrom
jong-kyung:fix/yarn-berry-recursive-filtered-remove
Sep 15, 2026
Merged

fengmk2 merged 5 commits into
voidzero-dev:mainfrom
jong-kyung:fix/yarn-berry-recursive-filtered-remove

Conversation

@jong-kyung

Copy link
Copy Markdown
Collaborator

Prevent vp remove --recursive --filter on Yarn Berry from removing dependencies in unselected workspaces.

Previously, recursive removal ignored filters and ran yarn remove --all. Keep filtered execution through workspaces foreach --all --include, but omit the inner remove --all so each invocation affects only its selected workspace.

@jong-kyung

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T07:55:56.398797Z 4750b0c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jong-kyung jong-kyung self-assigned this Sep 15, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be938767b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vp_pm_cli/src/resolution/commands/remove.rs
Comment thread crates/vp_pm_cli/src/resolution/commands/remove.rs
@jong-kyung
jong-kyung marked this pull request as draft September 15, 2026 06:56
@jong-kyung
jong-kyung marked this pull request as ready for review September 15, 2026 07:50
@jong-kyung

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 4750b0c55a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jong-kyung
jong-kyung requested a review from fengmk2 September 15, 2026 07:56
@fengmk2
fengmk2 merged commit e9dcf10 into voidzero-dev:main Sep 15, 2026
70 checks passed
@jong-kyung
jong-kyung deleted the fix/yarn-berry-recursive-filtered-remove branch September 15, 2026 09:17
fengmk2 added a commit that referenced this pull request Sep 15, 2026
Warn and ignore unsupported `--workspace-root` options in `add`,
`install`, `update`, and `why` for Yarn and Bun.
Allow Yarn Classic root additions by forwarding the option as `-W`,
including through `install <packages>`.

Follow-up to #2712.

Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants