fix(env): preserve existing .nvmrc pins - #2676
Open
ywenhao wants to merge 4 commits into
Open
Conversation
3 tasks
Member
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7df05c0ae3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fengmk2
approved these changes
Sep 12, 2026
fengmk2
added
test: e2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A project using
.nvmrcas its Node version source currently gets a second, higher-prioritydevEngines.runtimedeclaration whenvp env pinchanges its version. Vite+ then uses the new version while nvm and CI configured to read.nvmrckeep the old one.Pinning now updates an effective
.nvmrcin the current directory, preserving comments, reserved key/value lines, whitespace, and line endings. Higher-priority.node-versionand manifest declarations keep their existing behavior, and inherited parent files are not modified. The change also adds--target nvmrcand keeps pin inspection and unpin consistent with the new target. Pin inspection stops at a nearerengines.nodeconstraint instead of reporting a shadowed ancestor pin.Fixes #2675.
Validation
Validated on Linux x64 / WSL2 with the repository's
nightly-2026-08-02Rust toolchain:cargo build -p vp_global_cli --lockedcargo test -p vp_global_cli --locked: 491 passed, 2 ignored.cargo clippy -p vp_global_cli --all-targets --all-features --locked -- --deny warningswith the repository's existing lint allow-list: passed.cargo fmt --all --checkand repository-configuredvp fmt --check .: passed (491 files checked by Vite+).VP_SNAP_SKIP_FLAVORS=local cargo test -p vp_cli_snapshots --locked -- command_env_pin --test-threads=1: 16 passed, including 11 new CLI cases and 5 existing package-manager cases.devEngines.runtimewrite and stale.nvmrc. Snapshots were generated with the new binary and reviewed.The initial parallel snapshot comparison encountered two
Text file busy (os error 26)errors while starting the test harness'svp env setup, before the case steps. The full focused comparison passed with one test thread. Windows and macOS execution is left to CI.