fix(migrate): duplicate oxlint config arguments - #2671
Closed
yusuke99 wants to merge 4 commits into
Closed
Conversation
Member
|
@yusuke99 This feature can be postponed for now. We prefer that Vite+ projects still be configured in vite.config.ts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2037:
Summary
This PR fixes
vp lintfailing withargument '-c' cannot be used multiple times in this contextafter runningvp migrate.Currently,
vp migraterewrites an Oxlint script such asoxlint -c .oxlintrc.jsontovp lint -c .oxlintrc.json, even though.oxlintrc.jsonhas been merged intovite.config.ts. When the lint command runs, Vite+ also passes-c vite.config.tsto Oxlint, resulting in duplicate config arguments.What’s changed
Capture the detected Oxlint config and remove
-cor--configarguments when its merged intovite.config.ts— which makes the following changes when runningvp migrate:oxlint -c .oxlintrc.json→vp lint -c .oxlintrc.jsonoxlint -c .oxlintrc.json→vp lintNote
Since only
.oxlintrc.jsonand.oxlintrc.jsoncare automatically merged intovite.config.ts, explicit-cor--configfor custom file is preserved and passed directly to Oxlint.e.g.)
oxlint -c .my-custom-oxlint.config.json→vp lint -c .my-custom-oxlint.config.json