test: stabilize pnpm 11 workspace pack snapshot - #2655
Merged
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://test-fix-pnpm11-pack-snapshot-viteplus-dev.voidzero-docs.workers.dev (commit f152956)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
fengmk2
marked this pull request as ready for review
September 10, 2026 09:23
cpojer
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm@11.0.6packs workspace packages concurrently into the root directory. The root package can include child archives and cause this snapshot failure.Add
*.tgzto the fixture’s.npmignoreto exclude generated archives. Remove the staleout.jsonreads so the cleanup steps run. Regenerate the snapshot.The focused PTY snapshot test passes with
cargo test -p vp_cli_snapshots --test cli_snapshots -- command_pack_pnpm11_with_workspace. With a 200 ms rootprepackdelay, five runs reproduce the failure without the exclusion. Five runs with the exclusion pass.