Skip to content

test: stabilize pnpm 11 workspace pack snapshot - #2655

Merged
fengmk2 merged 3 commits into
mainfrom
test/fix-pnpm11-pack-snapshot
Sep 10, 2026
Merged

test: stabilize pnpm 11 workspace pack snapshot#2655
fengmk2 merged 3 commits into
mainfrom
test/fix-pnpm11-pack-snapshot

Conversation

@fengmk2

@fengmk2 fengmk2 commented Sep 10, 2026

Copy link
Copy Markdown
Member

pnpm@11.0.6 packs workspace packages concurrently into the root directory. The root package can include child archives and cause this snapshot failure.

Add *.tgz to the fixture’s .npmignore to exclude generated archives. Remove the stale out.json reads so the cleanup steps run. Regenerate the snapshot.

The focused PTY snapshot test passes with cargo test -p vp_cli_snapshots --test cli_snapshots -- command_pack_pnpm11_with_workspace. With a 200 ms root prepack delay, five runs reproduce the failure without the exclusion. Five runs with the exclusion pass.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 10, 2026

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://test-fix-pnpm11-pack-snapshot-viteplus-dev.voidzero-docs.workers.dev (commit f152956)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://a27a3dd0-viteplus-dev.voidzero-docs.workers.dev f152956 2026-09-10T14:25:37.485Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://f83fa3ca-viteplus-dev.voidzero-docs.workers.dev e30b7d8 2026-09-10T09:55:25.315Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://83cbd92c-viteplus-dev.voidzero-docs.workers.dev 12c0dbb 2026-09-10T09:14:29.427Z Visit the dashboard ↗

@fengmk2
fengmk2 marked this pull request as ready for review September 10, 2026 09:23
@fengmk2
fengmk2 merged commit b56066b into main Sep 10, 2026
42 checks passed
@fengmk2
fengmk2 deleted the test/fix-pnpm11-pack-snapshot branch September 10, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants