fix(cli): share Vite runtime through the core alias - #2617
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
CLI artifact sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
packages/cli/dist |
Directory total | 2.13 MiB | 2.14 MiB | +867 B (+0.04%) |
packages/core/dist |
Directory total | 3.92 MiB | 3.92 MiB | 0 B (0.00%) |
| Combined package dist | Directory total | 6.05 MiB | 6.06 MiB | +867 B (+0.01%) |
vp (Linux x64) |
Binary | 10.99 MiB | 10.99 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.76 MiB | 4.76 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | Binary | 31.93 MiB | 31.93 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.61 MiB | 12.61 MiB | +1.07 KiB (+0.01%) |
vp (macOS ARM64) |
Binary | 8.19 MiB | 8.19 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 4.15 MiB | 4.15 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | Binary | 39.55 MiB | 39.55 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 16.93 MiB | 16.93 MiB | +52 B (+0.00%) |
vp (Windows x64) |
Binary | 8.86 MiB | 8.86 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 3.88 MiB | 3.88 MiB | +1 B (+0.00%) |
| NAPI (Windows x64) | Binary | 26.81 MiB | 26.81 MiB | +2.00 KiB (+0.01%) |
| NAPI (Windows x64) | gzip -9 | 10.70 MiB | 10.70 MiB | +2.88 KiB (+0.03%) |
| Trampoline (Windows x64) | Binary | 14.00 KiB | 14.00 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 7.09 KiB | 7.09 KiB | 0 B (0.00%) |
| Installer (Windows x64) | Binary | 4.50 MiB | 4.50 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.11 MiB | 2.11 MiB | -2 B (-0.00%) |
Registry bridge build (
|
| Package | Version |
|---|---|
vite-plus |
0.0.0-commit.15cc57f55e221b26ca82e7475ce90d22af8b5cd0 |
@voidzero-dev/vite-plus-core |
0.0.0-commit.15cc57f55e221b26ca82e7475ce90d22af8b5cd0 |
Install the Vite+ CLI built from this commit, then migrate a project:
# macOS / Linux
curl -fsSL https://raw.githubusercontent.com/voidzero-dev/vite-plus/15cc57f55e221b26ca82e7475ce90d22af8b5cd0/packages/cli/install.sh | VP_PR_VERSION=2617 bash# Windows (PowerShell)
$env:VP_PR_VERSION="2617"; irm https://raw.githubusercontent.com/voidzero-dev/vite-plus/15cc57f55e221b26ca82e7475ce90d22af8b5cd0/packages/cli/install.ps1 | iexOr download the standalone Windows installer built from this commit:
| Architecture | Installer |
|---|---|
| x64 | vp-setup-x86_64-pc-windows-msvc.exe |
| Arm64 | vp-setup-aarch64-pc-windows-msvc.exe |
GitHub requires you to sign in and downloads each installer as a ZIP artifact. Extract vp-setup.exe, then run it against this preview build:
.\vp-setup.exe --version "0.0.0-commit.15cc57f55e221b26ca82e7475ce90d22af8b5cd0" --registry "https://registry-bridge.viteplus.dev/"After installing, upgrade the current project's vite-plus to this test build with:
vp migrateOr point your package manager at the bridge registry https://registry-bridge.viteplus.dev/:
| Package manager | Registry config |
|---|---|
| npm / pnpm / Bun | .npmrc: registry=https://registry-bridge.viteplus.dev/ |
| Yarn (v2+) | .yarnrc.yml: npmRegistryServer: "https://registry-bridge.viteplus.dev/" |
Then pin the build (vite aliases to vite-plus-core; pnpm can use a catalog, npm an overrides entry):
{
"devDependencies": {
"vite-plus": "0.0.0-commit.15cc57f55e221b26ca82e7475ce90d22af8b5cd0",
"vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.15cc57f55e221b26ca82e7475ce90d22af8b5cd0"
}
}
🐳 Docker preview imageBuilt from this PR's registry bridge build:
# remove any stale local copy from a previous run, then pull fresh
docker rmi ghcr.io/voidzero-dev/vite-plus:pr-2617 2>/dev/null; docker pull ghcr.io/voidzero-dev/vite-plus:pr-2617Quick check: docker run --rm ghcr.io/voidzero-dev/vite-plus:pr-2617 vp --versionSee docs/guide/docker.md for usage. |
sapphi-red
left a comment
There was a problem hiding this comment.
The cause and the fix makes sense to me
4ae9445 to
b26ca76
Compare
b26ca76 to
15cc57f
Compare
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
TanStack Start can return HTTP 404 when the CLI and plugins load separate core copies. The CLI now uses the exact
vitealias for its dependency, runtime imports, and generated exports.Version checks use the installed CLI manifest and the command's target project. They reject incompatible declared dependencies and permit incidental hoisted peers. The public config types retain
testwhen Vitest resolves a separate Vite copy.Preview packing and CI tarball installation preserve the alias. Version checks also support packages whose versions change after the build. The design is in
rfcs/vite-core-module-identity.md.Fixes #1391.